Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-08-04 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/#review94005 ---

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-31 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/#review93820 --- samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-29 Thread Yi Pan (Data Infrastructure)
On July 22, 2015, 7:08 p.m., Yi Pan (Data Infrastructure) wrote: samza-core/src/main/java/org/apache/samza/autoScaling/deployer/ConfigManager.java, line 318 https://reviews.apache.org/r/36006/diff/2/?file=1015151#file1015151line318 Did you update the container count in this

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-28 Thread Shadi A. Noghabi
On July 21, 2015, 9:53 p.m., Navina Ramesh wrote: Ideally, the job coordinator should act as the config manager. Since the chain of control is still from AppMaster to JobCoordinator (instead of the other way around), the only reasonable way to get this working is to have it as a

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-28 Thread Shadi A. Noghabi
On July 22, 2015, 6:25 p.m., Yi Pan (Data Infrastructure) wrote: samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala, line 130 https://reviews.apache.org/r/36006/diff/2/?file=1015156#file1015156line130 Question: can we move this code into the

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-28 Thread Shadi A. Noghabi
On July 22, 2015, 7:08 p.m., Yi Pan (Data Infrastructure) wrote: samza-core/src/main/java/org/apache/samza/autoScaling/deployer/ConfigManager.java, line 188 https://reviews.apache.org/r/36006/diff/2/?file=1015151#file1015151line188 Any reason the boostrap, skipUnreadMessages,

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-28 Thread Navina Ramesh
On July 21, 2015, 9:53 p.m., Navina Ramesh wrote: Ideally, the job coordinator should act as the config manager. Since the chain of control is still from AppMaster to JobCoordinator (instead of the other way around), the only reasonable way to get this working is to have it as a

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-27 Thread Shadi A. Noghabi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/ --- (Updated July 28, 2015, 2:22 a.m.) Review request for samza, Yi Pan (Data

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-22 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/#review92616 --- build.gradle (line 150)

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-22 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/#review92625 ---

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-21 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/#review92227 --- Ideally, the job coordinator should act as the config manager.

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-08 Thread Gustavo Anatoly F . V . SolĂ­s
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/#review90929 --- checkstyle/import-control.xml (line 126)

Re: Review Request 36006: Writing a tool to read from the coordinator stream and react to config changes accordingly.

2015-07-02 Thread Shadi A. Noghabi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36006/ --- (Updated July 2, 2015, 7:20 p.m.) Review request for samza, Yi Pan (Data