Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/ --- Review request for samza. Repository: samza Description --- Moved the cr

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/ --- (Updated July 3, 2015, 9:58 a.m.) Review request for samza. Repository: samza

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/#review90906 --- samza-api/src/main/java/org/apache/samza/system/SystemAdmin.java (l

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/ --- (Updated July 9, 2015, 2:39 p.m.) Review request for samza. Repository: samza

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/#review93019 --- samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinat

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/#review93093 --- The code LGTM. For testing, if we can verify this fix w/ a stateful

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/#review93454 --- samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinat

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

> On July 25, 2015, 1:33 a.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala, > > lines 121-125 > > > > > > this can be simplified a little: > > > > for ((s

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

> On July 25, 2015, 1:33 a.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala, > > lines 121-125 > > > > > > this can be simplified a little: > > > > for ((s

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

> On July 29, 2015, 2:45 p.m., Robert Zuljevic wrote: > > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala, > > lines 121-125 > > > > > > Did you mean something like this? > > > >

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

> On July 25, 2015, 1:33 a.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala, > > line 126 > > > > > > add logs for the case where the topic is already existied. Log

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

> On July 25, 2015, 1:33 a.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala, > > line 126 > > > > > > add logs for the case where the topic is already existied. Log

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

> On July 27, 2015, 7:36 a.m., Yi Pan (Data Infrastructure) wrote: > > The code LGTM. For testing, if we can verify this fix w/ a stateful > > StreamTask w/ changelog enabled with some partition numbers that are > > different from the default auto-creation partition number (i.e. 8) in > > Kafk

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

> On July 27, 2015, 7:36 a.m., Yi Pan (Data Infrastructure) wrote: > > The code LGTM. For testing, if we can verify this fix w/ a stateful > > StreamTask w/ changelog enabled with some partition numbers that are > > different from the default auto-creation partition number (i.e. 8) in > > Kafk

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/ --- (Updated Aug. 6, 2015, 6:55 a.m.) Review request for samza. Repository: samza

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/#review94687 --- @Robert, thanks! Code LGTM but need rebase. I will run the test afte

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/ --- (Updated Aug. 10, 2015, 7:47 a.m.) Review request for samza. Repository: samz

Re: Review Request 36163: SAMZA-690: changelog topic creation should not be in the container code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36163/ --- (Updated Aug. 10, 2015, 7:50 a.m.) Review request for samza. Repository: samz