Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/ --- Review request for samza. Repository: samza Description --- The followin

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/#review92825 --- samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointMana

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

> On July 23, 2015, 10:35 p.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/checkpoint/CheckpointManager.java, > > line 46 > > > > > > To be consistent, lets go with TaskName, not the String. Corre

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/ --- (Updated July 24, 2015, 12:27 p.m.) Review request for samza. Changes ---

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/#review92938 --- Thanks for picking this up! It feels good to look at a refactored co

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > Thanks for picking this up! It feels good to look at a refactored code. > > > > One suggestion: Please run all the intergration test (including the zopkio > > tests) before checking in this patch. I don't think we cleanly start and > > s

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/ --- (Updated July 27, 2015, 10:11 a.m.) Review request for samza. Changes ---

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, > > line 627 > > > > > > LocalityManager maintains "container to host"-level mapping

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/ --- (Updated July 27, 2015, 10:15 a.m.) Review request for samza. Repository: sam

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > Thanks for picking this up! It feels good to look at a refactored code. > > > > One suggestion: Please run all the intergration test (including the zopkio > > tests) before checking in this patch. I don't think we cleanly start and > > s

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > Thanks for picking this up! It feels good to look at a refactored code. > > > > One suggestion: Please run all the intergration test (including the zopkio > > tests) before checking in this patch. I don't think we cleanly start and > > s

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > Thanks for picking this up! It feels good to look at a refactored code. > > > > One suggestion: Please run all the intergration test (including the zopkio > > tests) before checking in this patch. I don't think we cleanly start and > > s

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > Thanks for picking this up! It feels good to look at a refactored code. > > > > One suggestion: Please run all the intergration test (including the zopkio > > tests) before checking in this patch. I don't think we cleanly start and > > s

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

> On July 24, 2015, 6:01 p.m., Navina Ramesh wrote: > > Thanks for picking this up! It feels good to look at a refactored code. > > > > One suggestion: Please run all the intergration test (including the zopkio > > tests) before checking in this patch. I don't think we cleanly start and > > s

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/ --- (Updated July 31, 2015, 12:49 p.m.) Review request for samza. Changes ---

Re: Review Request 36545: SAMZA-682 Refactor Coordinator stream messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36545/#review93826 --- Ship it! Thanks for testing with Zopkio ! - Navina Ramesh On Jul