----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37796/ -----------------------------------------------------------
Review request for samza. Repository: samza Description ------- Used IntelliJ IDEA to organise all imports in samza packages (src and test). Diffs ----- samza-core/src/main/scala/org/apache/samza/checkpoint/CheckpointTool.scala 2e3aeb8 samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 1464acc samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManagerMetrics.scala b6219ca samza-core/src/main/scala/org/apache/samza/config/DefaultChooserConfig.scala 4224393 samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 6d73bb9 samza-core/src/main/scala/org/apache/samza/config/MetricsConfig.scala c3fd8bf samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala be3f106 samza-core/src/main/scala/org/apache/samza/config/StreamConfig.scala e172589 samza-core/src/main/scala/org/apache/samza/config/SystemConfig.scala bf974df samza-core/src/main/scala/org/apache/samza/config/factories/PropertiesConfigFactory.scala ea91872 samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 61e228b samza-core/src/main/scala/org/apache/samza/container/SamzaContainerExceptionHandler.scala da4c098 samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 127f3a1 samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala d32a929 samza-core/src/main/scala/org/apache/samza/container/TaskInstanceExceptionHandler.scala 99b729f samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 8b86388 samza-core/src/main/scala/org/apache/samza/container/grouper/task/GroupByContainerCount.scala cb0a3bd samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala a926ce6 samza-core/src/main/scala/org/apache/samza/coordinator/server/HttpServer.scala c93f270 samza-core/src/main/scala/org/apache/samza/coordinator/server/ServletBase.scala 2732cca samza-core/src/main/scala/org/apache/samza/coordinator/stream/CoordinatorStreamSystemFactory.scala 9283812 samza-core/src/main/scala/org/apache/samza/coordinator/stream/CoordinatorStreamWriterCommandLine.scala 0c17800 samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 1673217 samza-core/src/main/scala/org/apache/samza/job/ShellCommandBuilder.scala c3f60ac samza-core/src/main/scala/org/apache/samza/job/local/ThreadJob.scala 63754c5 samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 5acfe87 samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala e6204c1 samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala 64daa0f samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala 40ffee2 samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala e966102 samza-core/src/main/scala/org/apache/samza/metrics/reporter/Metrics.scala d7aec8b samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsHeader.scala 8359b17 samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshot.scala ad08eb7 samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala fb438a4 samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala 60a8d84 samza-core/src/main/scala/org/apache/samza/serializers/ByteBufferSerde.scala 05c3e38 samza-core/src/main/scala/org/apache/samza/serializers/CheckpointSerde.scala fd8455a samza-core/src/main/scala/org/apache/samza/serializers/IntegerSerde.scala 46509f7 samza-core/src/main/scala/org/apache/samza/serializers/JsonSerde.scala 4b658c1 samza-core/src/main/scala/org/apache/samza/serializers/LongSerde.scala 41ff598 samza-core/src/main/scala/org/apache/samza/serializers/MetricsSnapshotSerde.scala 455dd34 samza-core/src/main/scala/org/apache/samza/serializers/SerdeManager.scala 066d894 samza-core/src/main/scala/org/apache/samza/serializers/SerializableSerde.scala c43f863 samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala 9588dcd samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala 155c3d1 samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 32fc771 samza-core/src/main/scala/org/apache/samza/system/SystemConsumersMetrics.scala e7f012f samza-core/src/main/scala/org/apache/samza/system/SystemProducers.scala a4b3ffb samza-core/src/main/scala/org/apache/samza/system/SystemProducersMetrics.scala 49d9aef samza-core/src/main/scala/org/apache/samza/system/chooser/BatchingChooser.scala b08817c samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala 1cd8e06 samza-core/src/main/scala/org/apache/samza/system/chooser/DefaultChooser.scala 95bd188 samza-core/src/main/scala/org/apache/samza/system/chooser/RoundRobinChooser.scala 4ecf1f2 samza-core/src/main/scala/org/apache/samza/system/chooser/TieredPriorityChooser.scala 6a3980e samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemAdmin.scala 460d11c samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemConsumer.scala 61dfd33 samza-core/src/main/scala/org/apache/samza/system/filereader/FileReaderSystemFactory.scala 9f2bb17 samza-core/src/main/scala/org/apache/samza/task/ReadableCoordinator.scala 6e1134d samza-core/src/main/scala/org/apache/samza/task/TaskInstanceCollector.scala 3b91180 samza-core/src/main/scala/org/apache/samza/util/CommandLine.scala f26501b samza-core/src/main/scala/org/apache/samza/util/ExponentialSleepStrategy.scala 4a04c13 samza-core/src/main/scala/org/apache/samza/util/Logging.scala 250de1e samza-core/src/main/scala/org/apache/samza/util/Util.scala c8438bd samza-core/src/test/scala/org/apache/samza/checkpoint/TestCheckpointTool.scala 00b8977 samza-core/src/test/scala/org/apache/samza/checkpoint/TestOffsetManager.scala c00ef91 samza-core/src/test/scala/org/apache/samza/config/TestStorageConfig.scala 81a35ec samza-core/src/test/scala/org/apache/samza/config/factories/TestPropertiesConfigFactory.scala 9688abb samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala b4d6f35 samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 6de8710 samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainerExceptionHandler.scala b1d100c samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5457f0e samza-core/src/test/scala/org/apache/samza/container/grouper/task/TestGroupByContainerCount.scala ddf1fde samza-core/src/test/scala/org/apache/samza/coordinator/TestJobCoordinator.scala 1393da8 samza-core/src/test/scala/org/apache/samza/coordinator/server/TestHttpServer.scala 6ce8aa9 samza-core/src/test/scala/org/apache/samza/job/TestJobRunner.scala 52057ed samza-core/src/test/scala/org/apache/samza/job/TestShellCommandBuilder.scala fd014b3 samza-core/src/test/scala/org/apache/samza/job/local/TestProcessJob.scala a1efe6f samza-core/src/test/scala/org/apache/samza/job/local/TestThreadJob.scala 4f3f511 samza-core/src/test/scala/org/apache/samza/metrics/TestJmxServer.scala f49cfaa samza-core/src/test/scala/org/apache/samza/metrics/TestMetricsHelper.scala bd3e5fe samza-core/src/test/scala/org/apache/samza/metrics/reporter/TestJmxReporter.scala 3cfd439 samza-core/src/test/scala/org/apache/samza/serializers/TestByteBufferSerde.scala 9401d70 samza-core/src/test/scala/org/apache/samza/serializers/TestByteSerde.scala f605762 samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala 4f1c14c samza-core/src/test/scala/org/apache/samza/serializers/TestLongSerde.scala 77a7498 samza-core/src/test/scala/org/apache/samza/serializers/TestMetricsSnapshotSerde.scala 5bc0be6 samza-core/src/test/scala/org/apache/samza/serializers/TestSerdeManager.scala 646d0c8 samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala 6491d09 samza-core/src/test/scala/org/apache/samza/system/TestStreamMetadataCache.scala 4716d97 samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala fbaa8ee samza-core/src/test/scala/org/apache/samza/system/TestSystemProducers.scala 45da7b6 samza-core/src/test/scala/org/apache/samza/system/chooser/MockMessageChooser.scala dcaaad4 samza-core/src/test/scala/org/apache/samza/system/chooser/TestBatchingChooser.scala 6d53697 samza-core/src/test/scala/org/apache/samza/system/chooser/TestBootstrappingChooser.scala 2e0180d samza-core/src/test/scala/org/apache/samza/system/chooser/TestDefaultChooser.scala 0909956 samza-core/src/test/scala/org/apache/samza/system/chooser/TestRoundRobinChooser.scala 1329e84 samza-core/src/test/scala/org/apache/samza/system/chooser/TestTieredPriorityChooser.scala 3e435ae samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemAdmin.scala 525d126 samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemConsumer.scala 5707bb4 samza-core/src/test/scala/org/apache/samza/system/filereader/TestFileReaderSystemFactory.scala c3295f3 samza-core/src/test/scala/org/apache/samza/task/TestReadableCoordinator.scala c141b5f samza-core/src/test/scala/org/apache/samza/util/TestUtil.scala d167263 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsConfig.scala 7993119 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemAdmin.scala 92eb447 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemFactory.scala ef3c20a samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemProducer.scala 1f4b5c4 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemProducerMetrics.scala 10b2226 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/writer/BinarySequenceFileHdfsWriter.scala ff89bc9 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/writer/Bucketer.scala 2b153a1 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/writer/HdfsWriter.scala b82018c samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/writer/JobNameDateTimeBucketer.scala b4377a2 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/writer/SequenceFileHdfsWriter.scala 46ade33 samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/writer/TextSequenceFileHdfsWriter.scala 2579bf0 samza-hdfs/src/test/scala/org/apache/samza/system/hdfs/TestHdfsSystemProducerTestSuite.scala c4b04a1 samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala 798033c samza-kafka/src/main/scala/org/apache/samza/config/RegExTopicGenerator.scala 78467bf samza-kafka/src/main/scala/org/apache/samza/serializers/KafkaSerde.scala d626b79 samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala c8cbc38 samza-kafka/src/main/scala/org/apache/samza/system/kafka/DefaultFetchSimpleConsumer.scala 5b4886a samza-kafka/src/main/scala/org/apache/samza/system/kafka/GetOffset.scala 5528702 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala aee33a9 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala c948d64 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala 741a176 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala d84bf06 samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala c0c34bf samza-kafka/src/main/scala/org/apache/samza/system/kafka/TopicMetadataCache.scala 82ecf1a samza-kafka/src/main/scala/org/apache/samza/util/ClientUtilTopicMetadataStore.scala 0f91622 samza-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala a7a095b samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaConfig.scala 85badf9 samza-kafka/src/test/scala/org/apache/samza/config/TestRegExTopicGenerator.scala 89ced34 samza-kafka/src/test/scala/org/apache/samza/serializers/TestKafkaSerde.scala 35bf688 samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestGetOffset.scala b959348 samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala d260f2d samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala 23fa939 samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala ce84b6d samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 39426d8 samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestTopicMetadataCache.scala 50c13ab samza-kafka/src/test/scala/org/apache/samza/utils/TestKafkaUtil.scala 848cfc8 samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStorageEngineFactory.scala 53147ad samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 72f25a3 samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala 571a50e samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala a423f7b samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala a428a16 samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 1112350 samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStoreMetrics.scala df8efae samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala e5a66a4 samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineMetrics.scala 233fba9 samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStore.scala 7bba6ff samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStoreMetrics.scala 743151a samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala 8e183ef samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStoreMetrics.scala 841e4a2 samza-kv/src/test/scala/org/apache/samza/storage/kv/MockKeyValueStore.scala 595dd0d samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala cc9c9f3 samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala 1ce7d25 samza-test/src/main/scala/org/apache/samza/test/performance/TestPerformanceTask.scala d1f1d84 samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 23f8a1a samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala a2b9279 samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala af42c6a samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala 03acfe1 samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala 0605386 samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala f667c83 samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 1743c86 samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnAppMasterListener.scala 6bf3046 samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnContainer.scala 7ab866f samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala 8dd70c9 samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJobFactory.scala 4e328a5 samza-yarn/src/main/scala/org/apache/samza/util/hadoop/HttpFileSystem.scala 7dff90e samza-yarn/src/main/scala/org/apache/samza/util/hadoop/HttpInputStream.scala a5458fb samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 09f4dc3 samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala 7fd5122 samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMaster.scala 7b7d86a samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala df5992e samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala 6f4bfaf samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala 2eec65f Diff: https://reviews.apache.org/r/37796/diff/ Testing ------- Thanks, Aleksandar Pejakovic
