Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-08-26 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- Review request for samza, Yan Fang, Chinmay Soman, Chris Riccomini, and Yi Pan (

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-08-26 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Aug. 26, 2015, 10:14 p.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-08-31 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/#review97059 --- Overall looks good to me. I have a few documentation/code reorganiza

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-08-31 Thread Navina Ramesh
> On Aug. 31, 2015, 9:02 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/container/LocalityManager.java, > > line 82 > > > > > > What's the reason to have both hostname and hos

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-08-31 Thread Navina Ramesh
> On Aug. 31, 2015, 9:02 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerRequestState.java, > > line 112 > > > > > > So, here to make sure that the request c

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-02 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Sept. 2, 2015, 7:17 p.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-02 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Sept. 2, 2015, 7:17 p.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-02 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/#review97517 --- samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaTaskMan

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-02 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Sept. 2, 2015, 9:33 p.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-08 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Sept. 8, 2015, 11:17 p.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-08 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Sept. 9, 2015, 12:28 a.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-10 Thread Yan Fang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/#review98316 --- samza-core/src/main/java/org/apache/samza/job/model/JobModel.java (

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-16 Thread Navina Ramesh
> On Sept. 11, 2015, 1:47 a.m., Yan Fang wrote: > > samza-core/src/main/java/org/apache/samza/job/model/JobModel.java, lines > > 65-72 > > > > > > duplicated code with line 116 - 122 Ok. Fixed it. > On Sept. 11, 2

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-16 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Sept. 16, 2015, 8:28 a.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-19 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Sept. 20, 2015, 4:45 a.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-21 Thread Yan Fang
> On Sept. 11, 2015, 1:47 a.m., Yan Fang wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAllocator.java, > > line 80 > > > > > > this getId is for the global container Id, right? > > Navina Ra

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-22 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/#review100063 --- samza-yarn/src/main/java/org/apache/samza/job/yarn/AbstractContain

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-22 Thread Navina Ramesh
> On Sept. 23, 2015, 1:38 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/AbstractContainerAllocator.java, > > line 57 > > > > > > nit: wouldn't it make more sense to

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-22 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/ --- (Updated Sept. 23, 2015, 3:59 a.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 37817: SAMZA-619 - Modify SamzaAppMaster to enable host-affinity

2015-09-25 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37817/#review100640 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On Sept. 23, 2