Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

2015-10-26 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39252/ --- (Updated Oct. 26, 2015, 6:45 p.m.) Review request for samza, Yan Fang, Chinmay

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

2015-10-26 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39252/#review104029 --- Except the check for the key variable arguments and minor comments

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

2015-10-23 Thread Navina Ramesh
> On Oct. 23, 2015, 1:22 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-core/src/main/java/org/apache/samza/config/JavaSerializerConfig.java, > > line 1 > > > > > > I noticed that we are creating new

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

2015-10-23 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39252/ --- (Updated Oct. 23, 2015, 11:46 p.m.) Review request for samza, Yan Fang,

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

2015-10-23 Thread Navina Ramesh
> On Oct. 23, 2015, 1:22 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/RocksDbKeyValueStoreHelper.java, > > line 34 > > > > > > nit: maybe rename to

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

2015-10-22 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39252/#review103702 --- Overall LGTM. Just a few minor comments on command options.

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

2015-10-19 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39252/#review103162 --- Ship it!

Re: Review Request 39252: SAMZA-626 - tool to read the RocksDb in a running job (Yan's patch)

2015-10-16 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39252/ --- (Updated Oct. 16, 2015, 11:44 p.m.) Review request for samza, Yan Fang,