Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/#review122363 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On Feb. 24,

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

> On Feb. 23, 2016, 10:26 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala, line 97 > > > > > > Usually this is done in Scala using option.getOrElse. So instead of > > add

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 24, 2016, 2:05 a.m.) Review request for samza, Navina Ramesh, Jag

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/#review120393 --- Fix it, then Ship it! Looks good to me. A few minor suggestions

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 23, 2016, 9:43 p.m.) Review request for samza, Navina Ramesh, Jag

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 18, 2016, 10:28 p.m.) Review request for samza, Navina Ramesh, Ja

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 18, 2016, 10:29 p.m.) Review request for samza, Navina Ramesh, Ja

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 18, 2016, 10:20 p.m.) Review request for samza, Navina Ramesh, Ja

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

> On Feb. 17, 2016, 5:34 p.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAllocator.java, > > line 57 > > > > > > This is a little subjective. My opinion on th

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/#review119488 --- samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAlloc

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

> On Feb. 11, 2016, 10:50 p.m., Navina Ramesh wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerUtil.java, line > > 244 > > > > > > You can modify the "TaskConfig.scala" to add an overrid method

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

> On Feb. 11, 2016, 10:50 p.m., Navina Ramesh wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAllocator.java, > > line 57 > > > > > > Is there any particular reason for updating state within th

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/#review118935 --- samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerAlloc

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

> On Feb. 10, 2016, 7:48 a.m., Yi Pan (Data Infrastructure) wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java, > > line 166 > > > > > > nit: I would prefer to keep UNUSED_CONTAINER_

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 10, 2016, 3:57 p.m.) Review request for samza, Navina Ramesh, Jag

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

> On Feb. 10, 2016, 7:19 a.m., Yi Pan (Data Infrastructure) wrote: > > First question: is this an independent patch or depend on RB 43074? It depends on 43074, but I see you've committed that one now, so this one should be good to go now. - Jake -

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/#review118610 --- LGTM. Just one minor comment. samza-yarn/src/main/java/org/apach

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/#review118604 --- First question: is this an independent patch or depend on RB 43074

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/#review118554 --- Ship it! Thanks for addressing the nits :-) Looks Great to me!

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- (Updated Feb. 10, 2016, 2:40 a.m.) Review request for samza, Navina Ramesh, Jag

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

> On Feb. 9, 2016, 2:18 a.m., Jagadish Venkatraman wrote: > > samza-yarn/src/main/java/org/apache/samza/job/yarn/ContainerUtil.java, line > > 261 > > > > > > Great work on separating out various methods :) > >

Re: Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/#review118346 --- samza-yarn/src/main/java/org/apache/samza/job/yarn/AbstractContai

Review Request 43350: SAMZA-867 Fix job restart/shutdown in the event of a node outage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43350/ --- Review request for samza, Navina Ramesh, Jagadish Venkatraman, and Yi Pan (Data