Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

> On May 5, 2016, 4:18 p.m., Jake Maes wrote: > > samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java, line 62 > > > > > > Since there is a change to the API, we probably shouldn't commit this > > unt

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/#review132109 --- Ship it! Ship It! - Yi Pan (Data Infrastructure) On May 6, 2

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

> On May 5, 2016, 9:19 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java, > > lines 25-31 > > > > > > I would actually move this doc to the interface. I would imagin

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

> On May 5, 2016, 9:19 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java, > > lines 25-31 > > > > > > I would actually move this doc to the interface. I would imagin

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/ --- (Updated May 6, 2016, 2:07 a.m.) Review request for samza, Boris Shkolnik, Chri

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

> On May 5, 2016, 4:18 p.m., Jake Maes wrote: > > samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java, line 62 > > > > > > Since there is a change to the API, we probably shouldn't commit this > > unt

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/#review131932 --- Fix it, then Ship it! Looks good. Minor tweak suggested below.

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

> On May 5, 2016, 3:22 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/storage/StoreProperties.java, line > > 40 > > > > > > It would be great to have some documentation about what each of the

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

> On May 5, 2016, 4:18 p.m., Jake Maes wrote: > > samza-api/src/main/java/org/apache/samza/storage/StorageEngine.java, line 62 > > > > > > Since there is a change to the API, we probably shouldn't commit this > > unt

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/ --- (Updated May 5, 2016, 9:13 p.m.) Review request for samza, Boris Shkolnik, Chri

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/#review131844 --- Fix it, then Ship it! samza-api/src/main/java/org/apache/samza

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/#review131835 --- Fix it, then Ship it! Looks good. I'd suggest moving non-change

Re: Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/ --- (Updated April 25, 2016, 5:25 p.m.) Review request for samza, Boris Shkolnik, C

Review Request 46644: SAMZA-889 - Change log not working properly with In memory Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46644/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, and Yi Pan (Data Infras