Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/#review132079 --- Ship it! Looks good ! +1 - Navina Ramesh On May 5, 2016, 8:4

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/ --- (Updated May 5, 2016, 8:41 p.m.) Review request for samza, Boris Shkolnik, Navi

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/ --- (Updated May 4, 2016, 12:30 a.m.) Review request for samza, Boris Shkolnik, Nav

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

> On May 3, 2016, 5:23 p.m., Chris Pettitt wrote: > > Looks good. Mostly minor stuff that you can choose to take or ignore. Appreciate the thoughtful comments. Implemented all of them. - Jake --- This is an automatically generated e-mai

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/ --- (Updated May 4, 2016, 12:18 a.m.) Review request for samza, Boris Shkolnik, Nav

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

> On May 3, 2016, 5:23 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/StreamPartitionCountMonitor.java, > > line 107 > > > > > > This is not thread-safe, but I believe it could

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

> On May 3, 2016, 5:23 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/StreamPartitionCountMonitor.java, > > line 107 > > > > > > This is not thread-safe, but I believe it could

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

> On May 3, 2016, 5:23 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/coordinator/StreamPartitionCountMonitor.java, > > line 107 > > > > > > This is not thread-safe, but I believe it could

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/#review131525 --- Fix it, then Ship it! Looks good. Mostly minor stuff that you c

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/ --- (Updated April 29, 2016, 11:38 p.m.) Review request for samza, Boris Shkolnik,

Re: Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/ --- (Updated April 29, 2016, 10:06 p.m.) Review request for samza, Boris Shkolnik,

Review Request 46856: SAMZA-943 Occasional test failure: TestStreamPartitionCountMonitor.testStartStopBehavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46856/ --- Review request for samza, Boris Shkolnik, Navina Ramesh, Jagadish Venkatraman, a