Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Yi Pan (Data Infrastructure)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132076 --- Ship it! LGTM! Thanks! - Yi Pan (Data Infrastructure) On May

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Jake Maes
> On May 6, 2016, 4:27 p.m., Boris Shkolnik wrote: > > samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala, line 92 > > > > > > Can you please add a log line, so we can know what port was chosen. see l

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Jake Maes
> On May 6, 2016, 4:25 p.m., Boris Shkolnik wrote: > > For my sake, can you explain why the first solution doesn't work with SSL? I've lost the link, but I found a few resources online that say the ServerPort and RegistryPort must be distinct for SSL. The deeper "why" probably requires a bette

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132060 --- samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scal

Re: Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-06 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/#review132059 --- Ship it! For my sake, can you explain why the first solution do

Review Request 47029: SAMZA-932 port collisions in JmxServer

2016-05-05 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47029/ --- Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina Rames