Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Oct. 1, 2016, 6:05 a.m.) Review request for samza, Boris Shkolnik, Chr

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Sept. 8, 2016, 5:03 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala, > > line 43 > > > > > > seems this is only needed for unit test. Please move the code to sc

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Sept. 8, 2016, 6:24 p.m., Xinyu Liu wrote: > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala, > > line 210 > > > > > > nit: no ";" at the end for scala fixed - Jagadish --

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Sept. 12, 2016, 9:25 p.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review148229 --- samza-core/src/main/scala/org/apache/samza/system/SystemConsumers

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review148210 --- samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 26, 2016, 7:51 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java, > > line 31 > > > > > > How likely are we to collide with this? Thats the problem

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Sept. 6, 2016, 4:02 p.m.) Review request for samza, Boris Shkolnik, Ch

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 29, 2016, 11:54 p.m., Xinyu Liu wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 375 > > > > > > No need to resume. This is running on the main thread. Not calling resume()

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 26, 2016, 7:51 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java, > > line 31 > > > > > > How likely are we to collide with this? Thats the problem

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 26, 2016, 7:51 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java, > > line 31 > > > > > > How likely are we to collide with this? Thats the problem

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Aug. 30, 2016, 12:32 a.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review147248 --- samza-api/src/main/java/org/apache/samza/system/SystemStreamParti

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review147245 --- Fix it, then Ship it! Generally looks great! Thanks a for clean

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 26, 2016, 5:06 p.m., Xinyu Liu wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 540 > > > > > > I think it might be cleaner to have two flags, one indicating > > endOfStrea

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Aug. 29, 2016, 11:47 p.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 26, 2016, 7:51 p.m., Chris Pettitt wrote: > > samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java, > > line 31 > > > > > > How likely are we to collide with this? Thats the problem

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 29, 2016, 4:19 p.m., Jake Maes wrote: > > samza-api/src/main/java/org/apache/samza/system/SystemStreamPartitionIterator.java, > > line 79 > > > > > > Would it be better to move this method to IncomingMessag

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review147135 --- samza-api/src/main/java/org/apache/samza/system/SystemStreamParti

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review147015 --- Fix it, then Ship it! samza-api/src/main/java/org/apache/samza

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review146982 --- samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Aug. 25, 2016, 11:52 p.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 25, 2016, 6:13 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 306 > > > > > > I think we only need the size(). Is the underlying data structure >

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

> On Aug. 25, 2016, 6:13 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala, > > line 140 > > > > > > Minor: Add documentation about what this is. All change

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Aug. 25, 2016, 11:43 p.m.) Review request for samza, Boris Shkolnik, C

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review146813 --- samza-api/src/main/java/org/apache/samza/system/IncomingMessageEn

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/#review146712 --- samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java

Re: Review Request 51346: SAMZA-974 - Support finite datasources in Samza that have a notion of End-Of-Stream

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51346/ --- (Updated Aug. 24, 2016, 9:03 p.m.) Review request for samza, Boris Shkolnik, Ch