Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2017-02-08 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164701 --- samza-core/src/main/scala/org/apache/samza/config/StorageConfig.s

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2017-02-07 Thread Shanthoosh Venkataraman
> On Oct. 24, 2016, 9:43 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala, > > line 138 > > > > > > s/is greater than/is older than. Fixed. > On Oct.

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2017-02-07 Thread Shanthoosh Venkataraman
> On Jan. 25, 2017, 10:28 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala, > > line 97 > > > > > > "Got default storage ..." Changed. > On Jan. 25, 2

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2017-01-25 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review163035 --- samza-core/src/main/scala/org/apache/samza/storage/TaskStorageMan

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-24 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153741 --- Ship it! Looks good to me, thanks. samza-core/src/main/scala/

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-22 Thread Shanthoosh Venkataraman
> On Oct. 21, 2016, 12:45 a.m., Prateek Maheshwari wrote: > > samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java, > > line 254 > > > > > > Does jobConfig.getChangeLog...() (implicit conversion) n

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-22 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- (Updated Oct. 22, 2016, 10:06 p.m.) Review request for samza. Repository: sam

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-22 Thread Shanthoosh Venkataraman
> On Oct. 20, 2016, 11:46 p.m., Boris Shkolnik wrote: > > samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala, > > line 132 > > > > > > nit. using System.currentTimeMillis directly makes it d

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-20 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153478 --- Looks pretty good, few final comments. samza-core/src/main/java/

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-20 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153468 --- samza-core/src/main/scala/org/apache/samza/config/StorageConfig.s

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-20 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review153476 --- Ship it! - Boris Shkolnik On Oct. 19, 2016, 10:04 p.m., Shant

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-19 Thread Shanthoosh Venkataraman
> On Oct. 17, 2016, 11:08 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala, > > line 156 > > > > > > Unrelated, but let's make this info. Done. > On

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-19 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- (Updated Oct. 19, 2016, 10:04 p.m.) Review request for samza. Repository: sam

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-17 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review152976 --- samza-core/src/main/scala/org/apache/samza/config/StorageConfig.s

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-17 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- (Updated Oct. 17, 2016, 10:40 p.m.) Review request for samza. Repository: sam

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-17 Thread Shanthoosh Venkataraman
> On Oct. 5, 2016, 2:08 a.m., Jake Maes wrote: > > Looks better, but I think there's still one major part missing. > > > > In order to have agreement between a kafka changelog and the task storage, > > the changelog should be created with the same delete.retention.ms property. > > > > There

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-17 Thread Jake Maes
> On Oct. 5, 2016, 2:08 a.m., Jake Maes wrote: > > Looks better, but I think there's still one major part missing. > > > > In order to have agreement between a kafka changelog and the task storage, > > the changelog should be created with the same delete.retention.ms property. > > > > There

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-13 Thread Shanthoosh Venkataraman
> On Oct. 5, 2016, 2:08 a.m., Jake Maes wrote: > > Looks better, but I think there's still one major part missing. > > > > In order to have agreement between a kafka changelog and the task storage, > > the changelog should be created with the same delete.retention.ms property. > > > > There

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-04 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review151439 --- Looks better, but I think there's still one major part missing.

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-04 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- (Updated Oct. 4, 2016, 11:33 p.m.) Review request for samza. Repository: samz

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-04 Thread Shanthoosh Venkataraman
> On Oct. 4, 2016, 1:57 a.m., Jake Maes wrote: > > samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala, > > line 293 > > > > > > 2 nits: > > 1. Can you swap this test with the next on

Re: Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-03 Thread Jake Maes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review151273 --- Looks good. Just a couple things below. samza-core/src/main/scal

Review Request 52476: Do not load task store which are older than delete tombstones.

2016-10-03 Thread Shanthoosh Venkataraman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/ --- Review request for samza. Repository: samza Description --- Every local