Re: Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/#review155478 --- Ship it! Looks pretty good, thanks!

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/ --- (Updated Nov. 9, 2016, 7:10 p.m.) Review request for samza, Chris Pettitt,

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

> On Nov. 2, 2016, 7:01 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/util/TimerClock.java, line 25 > > > > > > We have a HighResolutionClock that does this. I think you can use it > >

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

> On Nov. 2, 2016, 7:57 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala, > > line 65 > > > > > > I don't think we should ever be creating a default new

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/ --- (Updated Nov. 9, 2016, 2:14 a.m.) Review request for samza, Chris Pettitt,

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/#review155376 ---

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

> On Nov. 2, 2016, 12:57 p.m., Prateek Maheshwari wrote: > > Sorry for the late reply, didn't get an email notification for your replies. > On Nov. 2, 2016, 12:57 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala, > > line 65 > >

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/ --- (Updated Nov. 8, 2016, 12:47 a.m.) Review request for samza, Chris Pettitt,

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

> On Nov. 7, 2016, 5:27 p.m., Boris Shkolnik wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 550 > > > > > > So we don't need a callback on failure anymore? yes. This is a cleanup

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

> On Nov. 2, 2016, 7:57 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java, line 589 > > > > > > Typo: Envelope fixed. Thanks for catching this! > On Nov. 2,

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

> On Nov. 2, 2016, 7:01 p.m., Chris Pettitt wrote: > > samza-core/src/main/java/org/apache/samza/util/TimerClock.java, line 25 > > > > > > We have a HighResolutionClock that does this. I think you can use it > >

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/#review154602 --- samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/#review154611 --- Fix it, then Ship it! Can you get the numbers with all fixes

Re: Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/ --- (Updated Nov. 2, 2016, 5:56 p.m.) Review request for samza, Chris Pettitt,

Review Request 53282: SAMZA-1043: Samza performance improvements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53282/ --- Review request for samza. Repository: samza Description --- In the