Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/ --- (Updated Nov. 10, 2016, 6:58 p.m.) Review request for samza. Bugs: SAMZA-1042

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/ --- (Updated Nov. 10, 2016, 6:54 p.m.) Review request for samza. Bugs: SAMZA-1042

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

> On Nov. 9, 2016, 8:48 p.m., Navina Ramesh wrote: > > Is there any practical implementation of this interface . eg. adding to > > kafkasystemconsumer? Or is it expected in the future? I have used it with LiKafka for manual testing, but nothing to check in.. - Boris

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

> On Nov. 8, 2016, 11:52 p.m., Prateek Maheshwari wrote: > > samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala, > > line 239 > > > > > > Are you missing a foreach here? > > > > I thi

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/#review155495 --- Fix it, then Ship it! Is there any practical implementation of

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/#review155377 --- Some minor code style/documentation related comments. One correctn

Re: Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/ --- (Updated Nov. 4, 2016, 11:23 p.m.) Review request for samza. Bugs: SAMZA-1042

Review Request 53453: Add optional interface for SystemConsumer checkpontListener() for checkpoint notifications

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53453/ --- Review request for samza. Bugs: SAMZA-1042 https://issues.apache.org/jira/b