Re: Review Request 53826: added user document for Checkpoint callbacks

2016-11-22 Thread Boris Shkolnik
> On Nov. 22, 2016, 6:51 p.m., Prateek Maheshwari wrote: > > docs/learn/documentation/versioned/container/checkpointing.md, line 129 > > > > > > What does the "push system" mean? Maybe clarify/remove? done. > On N

Re: Review Request 53826: added user document for Checkpoint callbacks

2016-11-22 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156607 --- Ship it! Looks good. Minor comments. docs/learn/documentation

Re: Review Request 53826: added user document for Checkpoint callbacks

2016-11-18 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/ --- (Updated Nov. 19, 2016, 12:52 a.m.) Review request for samza. Bugs: SAMZA-104

Re: Review Request 53826: added user document for Checkpoint callbacks

2016-11-18 Thread Boris Shkolnik
> On Nov. 18, 2016, 2:36 a.m., Navina Ramesh wrote: > > docs/learn/documentation/versioned/container/checkpointing.md, line 130 > > > > > > Should we mention this since I don't know of a real world use-case that > >

Re: Review Request 53826: added user document for Checkpoint callbacks

2016-11-18 Thread Boris Shkolnik
> On Nov. 18, 2016, 3:17 a.m., Prateek Maheshwari wrote: > > Thanks!. Done. - Boris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156279 ---

Re: Review Request 53826: added user document for Checkpoint callbacks

2016-11-17 Thread Prateek Maheshwari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156279 --- docs/learn/documentation/versioned/container/checkpointing.md (li

Re: Review Request 53826: added user document for Checkpoint callbacks

2016-11-17 Thread Navina Ramesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/#review156276 --- Fix it, then Ship it! lgtm! docs/learn/documentation/versione

Review Request 53826: added user document for Checkpoint callbacks

2016-11-16 Thread Boris Shkolnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53826/ --- Review request for samza. Bugs: SAMZA-1046 https://issues.apache.org/jira/b