Re: [sc-dev] ScRange::Parse return values

2007-11-05 Thread Noel Power
Hi Eike On Fri, 2007-11-02 at 20:00 +0100, Eike Rathke wrote: > Hi Noel, > > So, in a calm minute now.. sorry for the long gap, that UI/feature > freeze nearing is always distracting ;) it's ok, I was off for a couple of day the end of last week anyway :-) only now catching up > .. > Looks strang

Re: [sc-dev] ScRange::Parse return values

2007-10-24 Thread Noel Power
Hi Eike, But there seems to be ( possibly ) be a bug in the lcl_ScRange_Parse_XL_Header which it seems will always sets some SCA_VALID...2 bits e.g. nFlags |= SCA_VALID_TAB2 | SCA_TAB2_ABSOLUTE - ( if only only single cell address with sheet ref e.g. Sheet1!R1C1 ) or nFlags |= SCA_VALID_TA

Re: [sc-dev] ScRange::Parse return values

2007-10-24 Thread Noel Power
Hi Eike, On Wed, 2007-10-24 at 13:15 +0200, Eike Rathke wrote: > I think it should instead be > > if ((nRes & SCA_VALID ) && nTmp1 && !nTmp2) > nRes |= ((nRes & 0x070f) << 4); > > This because we only want to modify the result if ParseAny did not > return any SCA_VALID_...2 bit for

Re: [sc-dev] ScRange::Parse return values

2007-10-23 Thread Noel Power
Hi Eike, the latest version of the patch is here http://svn.gnome.org/viewvc/ooo-build/trunk/patches/ooxml/xmlfilter-fixup-singlerange-sheetref.diff > + if ( (nRes & SCA_VALID ) && ( nTmp1 == > nStartRangeBits ) ) > + { > +

Re: [sc-dev] ScRange::Parse return values

2007-10-23 Thread Noel Power
Hi Eike thanks for the info :-) On Tue, 2007-10-23 at 14:59 +0200, Eike Rathke wrote: > Hi Noel, > > On Tuesday, 2007-10-23 12:32:25 +0100, Noel Power wrote: > > > yes you are right, I am just passing SCA_VALID as the nMask so I didn't > > see this. Given

Re: [sc-dev] ScRange::Parse return values

2007-10-23 Thread Noel Power
Hi Eike, On Tue, 2007-10-23 at 12:32 +0200, Eike Rathke wrote: > Hi Noel, > You were faster than me.. well I would have been faster still if I had re-read fully (and understood) the content of original thread ;-) > I also wanted to suggest to use > ScRange::ParseAny. However, care must be taken

Re: [sc-dev] ScRange::Parse return values

2007-10-23 Thread Noel Power
sary we could to mitigate risks by just using the ScRange::ParseAny for the XL_XX addressing variants opinions? Noel On Mon, 2007-10-22 at 12:35 +0100, Noel Power wrote: > Hi Niklas/Eike > > On Mon, 2007-07-02 at 12:00 +0100, Noel Power wrote: > > Hi, > > > > Final

Re: [sc-dev] ScRange::Parse return values

2007-10-22 Thread Noel Power
Hi Niklas/Eike On Mon, 2007-07-02 at 12:00 +0100, Noel Power wrote: > Hi, > > Finally go a chance to apply the changes from the cws and glad to say > these changes don't seem to affect the tests that I have :-) > > Thanks, > > Noel but then I got a problem tha

Re: [sc-dev] UNO API for extended sheet filters

2007-07-20 Thread Noel Power
Hi Kohei Kohei Yoshida wrote: The presence of the base struct is to ease the handling of these different filter types, so that the consumer of this API can store all filters in a single container without sacrificing type safety too much. thats a nice idea :-) These data structures are excha

Re: [sc-dev] ScRange::Parse return values

2007-07-03 Thread Noel Power
Hi Eike, On Mon, 2007-07-02 at 14:32 +0200, Eike Rathke wrote: > Hi Noel, > > On Monday, 2007-07-02 12:00:12 +0100, Noel Power wrote: > > > Finally go a chance to apply the changes from the cws and glad to say > > these changes don't seem to affect the tests that I

Re: [sc-dev] ScRange::Parse return values

2007-07-02 Thread Noel Power
Hi, Finally go a chance to apply the changes from the cws and glad to say these changes don't seem to affect the tests that I have :-) Thanks, Noel On Fri, 2007-06-29 at 09:41 +0100, Noel Power wrote: > Hi Niklas > On Wed, 2007-06-27 at 17:43 +0200, Niklas Nebel wrote: > >

Re: [sc-dev] ScRange::Parse return values

2007-06-29 Thread Noel Power
Hi Niklas On Wed, 2007-06-27 at 17:43 +0200, Niklas Nebel wrote: > Noel Power wrote: > > If you can let me know when you commit the change ( and to what > > file(s) ) I will at least run some tests against that as a sanity check. > > It's in sc/source/core/tool/address.c

Re: [sc-dev] ScRange::Parse return values

2007-06-26 Thread Noel Power
filter02 CWS. If you can let me know when you commit the change ( and to what file(s) ) I will at least run some tests against that as a sanity check. Noel -- Noel Power OpenOffice Developer Novell Ireland Software Limited Corrig Court, Corrig Road Sandyford Business Estate, Sandyford Dubli

Re: [sc-dev] ScRange::Parse return values

2007-06-26 Thread Noel Power
------ > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > -- Noel Power OpenOffice Developer Novell Ireland Software Limited Corrig Court, Corrig Road Sandyford Business Estate,

Re: [sc-dev] cws-npower6 some module inspection required for screlated files

2007-02-26 Thread Noel Power
a piece of string? > Is it already considered a QA-able feature, or > is it just preparation for other CWSes? So, currently it is certainly usable to a certain extent ( though not as usable yet as the ooo-build version ). Right now its not qa'able as such, I think alot supporting changes

[sc-dev] cws-npower6 some module inspection required for sc related files

2007-02-23 Thread Noel Power
d asap as there are many many more cws(s) to be built ontop of this one. -- Noel Power OpenOffice Developer [EMAIL PROTECTED] Novell, Inc. Software for the Open Enterprise www.novell.com/open SUSEĀ® Linux Enterprise 10 Your Linux