[GitHub] [incubator-sdap-nexus] RKuttruff opened a new pull request, #181: Preserve insitu schema

2022-07-20 Thread GitBox
RKuttruff opened a new pull request, #181: URL: https://github.com/apache/incubator-sdap-nexus/pull/181 Matchup makes repeated calls to `query_insitu_schema()` in the insitu module, which results in a severe performance penalty due to repeatedly hitting the insitu API for the same data. Thi

[GitHub] [incubator-sdap-nexus] ngachung merged pull request #179: SDAP-396: saildrone insitu

2022-07-20 Thread GitBox
ngachung merged PR #179: URL: https://github.com/apache/incubator-sdap-nexus/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sd

[GitHub] [incubator-sdap-nexus] ngachung merged pull request #175: Fix CSV/NetCDF bug

2022-07-20 Thread GitBox
ngachung merged PR #175: URL: https://github.com/apache/incubator-sdap-nexus/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sd

[GitHub] [incubator-sdap-nexus] ngachung merged pull request #180: SDAP-397: Requested matchup updates

2022-07-20 Thread GitBox
ngachung merged PR #180: URL: https://github.com/apache/incubator-sdap-nexus/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sd

[GitHub] [incubator-sdap-nexus] ngachung merged pull request #176: Fix satellite to satellite matchup

2022-07-20 Thread GitBox
ngachung merged PR #176: URL: https://github.com/apache/incubator-sdap-nexus/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sd

[GitHub] [incubator-sdap-nexus] ngachung commented on pull request #179: SDAP-396: saildrone insitu

2022-07-20 Thread GitBox
ngachung commented on PR #179: URL: https://github.com/apache/incubator-sdap-nexus/pull/179#issuecomment-1190587866 Thank you! That's expected as I filtered out only matches that contained mass_concentration_of_chlorophyll_in_sea_water. -- This is an automated message from the Apache Git

[GitHub] [incubator-sdap-nexus] skorper commented on pull request #179: SDAP-396: saildrone insitu

2022-07-20 Thread GitBox
skorper commented on PR #179: URL: https://github.com/apache/incubator-sdap-nexus/pull/179#issuecomment-1190504757 @ngachung Ran this same request locally using this branch -- it seemed to match to more than 6 points. See output below. I ran this through a script I wrote to verify th

[GitHub] [incubator-sdap-nexus] skorper commented on pull request #180: SDAP-397: Requested matchup updates

2022-07-20 Thread GitBox
skorper commented on PR #180: URL: https://github.com/apache/incubator-sdap-nexus/pull/180#issuecomment-1190486320 Latest update: - Query insitu schema endpoint to get units for insitu observations - Use "meta" field to populate "id" field for insitu - Moved depth to top level a

[GitHub] [incubator-sdap-nexus] skorper commented on pull request #180: SDAP-397: Requested matchup updates

2022-07-20 Thread GitBox
skorper commented on PR #180: URL: https://github.com/apache/incubator-sdap-nexus/pull/180#issuecomment-1190433207 Thanks for your review @ngachung. - I wondered that as well. The depth field should probably be at the root level alongside lat/lon/time. - Thank you! - Thanks! I

[GitHub] [incubator-sdap-nexus] ngachung commented on pull request #180: SDAP-397: Requested matchup updates

2022-07-20 Thread GitBox
ngachung commented on PR #180: URL: https://github.com/apache/incubator-sdap-nexus/pull/180#issuecomment-1190348199 Thank you, @skorper. - We can discuss at our next team meeting, but I wonder if depth should just be added as an attribute similar to lat, lon for both primary and seco

[GitHub] [incubator-sdap-nexus] ngachung commented on pull request #179: SDAP-396: saildrone insitu

2022-07-20 Thread GitBox
ngachung commented on PR #179: URL: https://github.com/apache/incubator-sdap-nexus/pull/179#issuecomment-1190328943 Thank you, @skorper. This is a call we used for the notebook demo that returned 6 matches. https://doms.jpl.nasa.gov/match_spark?primary=JPL-L4-MRVA-CHLA-GLOB-v3.0&secondary=

[GitHub] [incubator-sdap-nexus] skorper opened a new pull request, #180: SDAP-397: Requested matchup updates

2022-07-20 Thread GitBox
skorper opened a new pull request, #180: URL: https://github.com/apache/incubator-sdap-nexus/pull/180 https://issues.apache.org/jira/browse/SDAP-397 - Added depth to matchup insitu output - Added in the "data" field (see example below). Is this a desirable location for this value

[GitHub] [incubator-sdap-nexus] skorper opened a new pull request, #179: SDAP-396: saildrone insitu

2022-07-20 Thread GitBox
skorper opened a new pull request, #179: URL: https://github.com/apache/incubator-sdap-nexus/pull/179 https://issues.apache.org/jira/browse/SDAP-396 Added saildrone insitu API. I haven't had much luck finding a request that results in a matchup. I'm trying to find overlap with