[GitHub] [incubator-sdap-nexus] skorper opened a new pull request, #172: SDAP-371: Fix domssubset API

[GitBox]

skorper opened a new pull request, #172:
URL: https://github.com/apache/incubator-sdap-nexus/pull/172

   https://issues.apache.org/jira/browse/SDAP-371
   
   
   ### Summary of changes
   
   - Renamed endpoint `/domssubset` -> `/cdmssubset`
   - Updated openapi spec with "cdms" terminology
   - Added unit tests for toZip and toCsv
   - Moved `query_edge` function into a new python module 
`analysis/webservice/algorithms/doms/insitu.py` and changed "edge" terminology 
to "insitu"
     - Updated matchup to use this, removed query_edge
   - Updated subsetter to, rather than querying SDAP, use existing functions to 
query satellite and insitu data
   - ZIP contains one CSV file per dataset. File is named like 
"\<dataset-name\>.csv"
   - Added default of 0/5 for min/max depth because AWS insitu API requires 
those fields
   
   
   ### Testing 
   
   In addition to unit tests also ran locally with the following request:
   
   ```
   
{{big_data_url}}/cdmssubset?dataset=ASCATB-L2-Coastal&parameter=sea_water_temperature&startTime=2018-09-24T00:00:00Z&endTime=2018-09-30T00:00:00Z&b=160,-30,180,-25&output=ZIP&insitu=ICOADS%20Release%203.0&platforms=42&depthMin=0&depthMax=5
   ```
   
   Response: 
[response.zip](https://github.com/apache/incubator-sdap-nexus/files/9067888/response.zip)
   
   Also tested matchup to make sure nothing was broken due to the new insitu 
module -- response was as expected. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org