Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff merged PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff commented on PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#issuecomment-1977712682 > I think we should also remove VERSION.txt and manage the version solely in the pyproject.toml file Done -- This is an automated message from the Apache Git

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

skorper commented on PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#issuecomment-1977707259 I think we should also remove VERSION.txt and manage the version solely in the pyproject.toml file -- This is an automated message from the Apache Git Service. To respond

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff commented on PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#issuecomment-1977690230 I agree. Old files have been removed Ingester common & collection manager still have their setup.py, but they never used conda -- This is an automated message

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

skorper commented on PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#issuecomment-1977680451 > > What about the setup.py files, requirements.txt files, conda requirements files etc? Those are still in the repo currently. > > Also, what are your thoughts about

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff commented on code in PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#discussion_r1511932667 ## docker/nexus-webapp/entrypoint.sh: ## @@ -0,0 +1,133 @@ +#!/bin/bash Review Comment: Done -- This is an automated message from the Apache Git

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff commented on code in PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#discussion_r1511931587 ## docker/nexus-webapp/entrypoint.sh: ## @@ -0,0 +1,133 @@ +#!/bin/bash Review Comment: Oh lol, that makes sense! I'll delete the .old It was

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

skorper commented on code in PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#discussion_r1511929498 ## docker/nexus-webapp/entrypoint.sh: ## @@ -0,0 +1,133 @@ +#!/bin/bash Review Comment: What the heck, I swear I put this comment on Dockerfile.old

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff commented on code in PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#discussion_r1511913900 ## pyproject.toml: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff commented on code in PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#discussion_r1511912292 ## docker/nexus-webapp/entrypoint.sh: ## @@ -0,0 +1,133 @@ +#!/bin/bash Review Comment: I think we may need this file. It was the entrypoint for the

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff commented on PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#issuecomment-1977626124 > What about the setup.py files, requirements.txt files, conda requirements files etc? Those are still in the repo currently. > > Also, what are your thoughts about

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

skorper commented on code in PR #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301#discussion_r1511902837 ## pyproject.toml: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

[PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff opened a new pull request, #301: URL: https://github.com/apache/incubator-sdap-nexus/pull/301 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff closed pull request #300: SDAP-511 - Switch package manager to poetry URL: https://github.com/apache/incubator-sdap-nexus/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] SDAP-511 - Switch package manager to poetry [incubator-sdap-nexus]

RKuttruff opened a new pull request, #300: URL: https://github.com/apache/incubator-sdap-nexus/pull/300 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To