[GitHub] [incubator-sedona] yitao-li opened a new pull request #525: [bugfix] fix user-data mutability issue with toDF

2021-05-17 Thread GitBox
yitao-li opened a new pull request #525: URL: https://github.com/apache/incubator-sedona/pull/525 Signed-off-by: Yitao Li ## Is this PR related to a proposed Issue? I think we should create an issue for it. The problem is currently if `Adapter.toDf()` is called with a `

[GitHub] [incubator-sedona] yitao-li commented on a change in pull request #521: [SEDONA-31] R interface for Apache Sedona

2021-05-17 Thread GitBox
yitao-li commented on a change in pull request #521: URL: https://github.com/apache/incubator-sedona/pull/521#discussion_r633681332 ## File path: R/sparklyr.sedona/tests/testthat/test-sdf-interface.R ## @@ -0,0 +1,43 @@ +context("sdf interface") + +sc <- testthat_spark_connecti

[GitHub] [incubator-sedona] shantanuaggarwal2695 commented on a change in pull request #523: [SEDONA-30] Add ST_GeomFromRaster, ST_GeomWithBandsFromGeoTiff and ST_GetBand in Sedona

2021-05-17 Thread GitBox
shantanuaggarwal2695 commented on a change in pull request #523: URL: https://github.com/apache/incubator-sedona/pull/523#discussion_r633123832 ## File path: sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster.scala ## @@ -0,0 +1,223 @@ +/* + * Licensed to th

[GitHub] [incubator-sedona] yitao-li commented on a change in pull request #521: [SEDONA-31] R interface for Apache Sedona

2021-05-17 Thread GitBox
yitao-li commented on a change in pull request #521: URL: https://github.com/apache/incubator-sedona/pull/521#discussion_r633681332 ## File path: R/sparklyr.sedona/tests/testthat/test-sdf-interface.R ## @@ -0,0 +1,43 @@ +context("sdf interface") + +sc <- testthat_spark_connecti

[GitHub] [incubator-sedona] yitao-li commented on a change in pull request #521: [SEDONA-31] R interface for Apache Sedona

2021-05-17 Thread GitBox
yitao-li commented on a change in pull request #521: URL: https://github.com/apache/incubator-sedona/pull/521#discussion_r633681332 ## File path: R/sparklyr.sedona/tests/testthat/test-sdf-interface.R ## @@ -0,0 +1,43 @@ +context("sdf interface") + +sc <- testthat_spark_connecti

[GitHub] [incubator-sedona] jiayuasu commented on pull request #525: [bugfix] address user-data mutability issue with `Adapter.toDF()`

2021-05-17 Thread GitBox
jiayuasu commented on pull request #525: URL: https://github.com/apache/incubator-sedona/pull/525#issuecomment-842730237 @yitao-li This looks good to me. I actually ran into this issue before but wasn't able to identify the issue. Thanks for pointing this out. If you can add some test case

[GitHub] [incubator-sedona] jiayuasu commented on pull request #516: [Sedona-28] shape&wkb ser de

2021-05-17 Thread GitBox
jiayuasu commented on pull request #516: URL: https://github.com/apache/incubator-sedona/pull/516#issuecomment-842735525 @netanel246 Any update on the SQL part? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (SEDONA-33) Fix the copyright issue according to ASF policy after the initial release

2021-05-17 Thread Jia Yu (Jira)
Jia Yu created SEDONA-33: Summary: Fix the copyright issue according to ASF policy after the initial release Key: SEDONA-33 URL: https://issues.apache.org/jira/browse/SEDONA-33 Project: Apache Sedona

[GitHub] [incubator-sedona] jiayuasu opened a new pull request #526: [SEDONA-33] Fix the copyright issue according to ASF policy after the initial release

2021-05-17 Thread GitBox
jiayuasu opened a new pull request #526: URL: https://github.com/apache/incubator-sedona/pull/526 ## Is this PR related to a proposed Issue? https://issues.apache.org/jira/browse/SEDONA-33 ## What changes were proposed in this PR? ## How was this patch tested? ##

[jira] [Created] (SEDONA-34) Stop using real world data in unit tests

2021-05-17 Thread Jia Yu (Jira)
Jia Yu created SEDONA-34: Summary: Stop using real world data in unit tests Key: SEDONA-34 URL: https://issues.apache.org/jira/browse/SEDONA-34 Project: Apache Sedona Issue Type: Task Rep

[GitHub] [incubator-sedona] jiayuasu opened a new pull request #527: [SEDONA-34] Stop using real world data in unit tests

2021-05-17 Thread GitBox
jiayuasu opened a new pull request #527: URL: https://github.com/apache/incubator-sedona/pull/527 ## Is this PR related to a proposed Issue? https://issues.apache.org/jira/browse/SEDONA-34 ## What changes were proposed in this PR? ## How was this patch tested? ##