[jira] [Created] (SEDONA-132) Create common module for SQL functions

2022-07-05 Thread Adam Binford (Jira)
Adam Binford created SEDONA-132: --- Summary: Create common module for SQL functions Key: SEDONA-132 URL: https://issues.apache.org/jira/browse/SEDONA-132 Project: Apache Sedona Issue Type: Improv

[GitHub] [incubator-sedona] Kimahriman opened a new pull request, #647: WIP: [SEDONA-132] Move some functions to a common module

2022-07-05 Thread GitBox
Kimahriman opened a new pull request, #647: URL: https://github.com/apache/incubator-sedona/pull/647 ## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.

[GitHub] [incubator-sedona] Kimahriman commented on pull request #647: WIP: [SEDONA-132] Move some functions to a common module

2022-07-05 Thread GitBox
Kimahriman commented on PR #647: URL: https://github.com/apache/incubator-sedona/pull/647#issuecomment-1175562463 Started playing around with this and wanted to get some thoughts. Figured out some Scala magic to reduce the boilerplate needed for each Spark function. Only converted a few to

[GitHub] [incubator-sedona] Kimahriman commented on a diff in pull request #647: WIP: [SEDONA-132] Move some functions to a common module

2022-07-05 Thread GitBox
Kimahriman commented on code in PR #647: URL: https://github.com/apache/incubator-sedona/pull/647#discussion_r914254002 ## .github/workflows/java.yml: ## @@ -3,7 +3,7 @@ name: Scala and Java build on: push: branches: - - master + - '*' Review Comment: This

[GitHub] [incubator-sedona] Kimahriman commented on a diff in pull request #647: WIP: [SEDONA-132] Move some functions to a common module

2022-07-05 Thread GitBox
Kimahriman commented on code in PR #647: URL: https://github.com/apache/incubator-sedona/pull/647#discussion_r914254218 ## common/src/main/java/org/apache/sedona/Functions.java: ## @@ -0,0 +1,28 @@ +package org.apache.sedona; Review Comment: Wasn't sure if it should go in an

[GitHub] [incubator-sedona] Kimahriman commented on a diff in pull request #647: WIP: [SEDONA-132] Move some functions to a common module

2022-07-05 Thread GitBox
Kimahriman commented on code in PR #647: URL: https://github.com/apache/incubator-sedona/pull/647#discussion_r914300019 ## python-adapter/pom.xml: ## @@ -47,6 +47,11 @@ jts2geojson ${jts2geojson.version} + +org.apache.sedon