[GitHub] [incubator-sedona] douglasdennis commented on a diff in pull request #693: [SEDONA-166] Support type-safe dataframe style API

2022-09-21 Thread GitBox
douglasdennis commented on code in PR #693: URL: https://github.com/apache/incubator-sedona/pull/693#discussion_r977229737 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_aggregates.scala: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #693: [SEDONA-166] Support type-safe dataframe style API

2022-09-21 Thread GitBox
jiayuasu commented on code in PR #693: URL: https://github.com/apache/incubator-sedona/pull/693#discussion_r977225481 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_aggregates.scala: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [incubator-sedona] douglasdennis commented on a diff in pull request #693: [SEDONA-166] Support type-safe dataframe style API

2022-09-21 Thread GitBox
douglasdennis commented on code in PR #693: URL: https://github.com/apache/incubator-sedona/pull/693#discussion_r977222536 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_aggregates.scala: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-sedona] jiayuasu commented on pull request #693: [SEDONA-166] Support type-safe dataframe style API

2022-09-21 Thread GitBox
jiayuasu commented on PR #693: URL: https://github.com/apache/incubator-sedona/pull/693#issuecomment-1254539535 @douglasdennis Haha, no problem. This PR looks pretty nice. Keep up the good work! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-sedona] jiayuasu commented on pull request #692: [SEDONA-170] Add ST_AddPoint and ST_RemovePoint to the Flink API

2022-09-21 Thread GitBox
jiayuasu commented on PR #692: URL: https://github.com/apache/incubator-sedona/pull/692#issuecomment-1254538260 This looks interesting. Does Flink already support ESRI geometry type before your PR? I checked their doc

[GitHub] [incubator-sedona] douglasdennis commented on pull request #693: [SEDONA-166] Support type-safe dataframe style API

2022-09-21 Thread GitBox
douglasdennis commented on PR #693: URL: https://github.com/apache/incubator-sedona/pull/693#issuecomment-1254536996 This is pretty embarrassing. This was meant to PR against my own fork's master to get the build action to run. While most of these changes are approaching done (on the Scala

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #693: Dataframe api

2022-09-21 Thread GitBox
jiayuasu commented on code in PR #693: URL: https://github.com/apache/incubator-sedona/pull/693#discussion_r977198754 ## sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_aggregates.scala: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [incubator-sedona] douglasdennis opened a new pull request, #693: Dataframe api

2022-09-21 Thread GitBox
douglasdennis opened a new pull request, #693: URL: https://github.com/apache/incubator-sedona/pull/693 ## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development

[jira] [Commented] (SEDONA-156) predicate pushdown support for GeoParquet

2022-09-21 Thread RJ Marcus (Jira)
[ https://issues.apache.org/jira/browse/SEDONA-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607857#comment-17607857 ] RJ Marcus commented on SEDONA-156: -- Hello [~jiayu] , I have spent a while working on SEDONA-156 and I