[jira] [Created] (SEDONA-250) R Deprecate use of Spark 2.4

2023-02-17 Thread Gregoire Leleu (Jira)
Gregoire Leleu created SEDONA-250: - Summary: R Deprecate use of Spark 2.4 Key: SEDONA-250 URL: https://issues.apache.org/jira/browse/SEDONA-250 Project: Apache Sedona Issue Type: Bug

[jira] [Commented] (SEDONA-248) R – Let dev version of R package use SNAPSHOT jars

2023-02-17 Thread Jia Yu (Jira)
[ https://issues.apache.org/jira/browse/SEDONA-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690634#comment-17690634 ] Jia Yu commented on SEDONA-248: --- [~gregleleu]   1. In Sedona Python, to use a Sedona SNAP

[GitHub] [sedona] jiayuasu commented on pull request #772: [SEDONA-249] Add jvm flags for running tests on Java 17

2023-02-17 Thread via GitHub
jiayuasu commented on PR #772: URL: https://github.com/apache/sedona/pull/772#issuecomment-1435323043 @umartin Yes! Can you remove that flaky test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (SEDONA-248) R – Let dev version of R package use SNAPSHOT jars

2023-02-17 Thread Gregoire Leleu (Jira)
[ https://issues.apache.org/jira/browse/SEDONA-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690586#comment-17690586 ] Gregoire Leleu commented on SEDONA-248: --- Yes, this is fine for local dev, but it's

[GitHub] [sedona] umartin commented on pull request #772: [SEDONA-249] Add jvm flags for running tests on Java 17

2023-02-17 Thread via GitHub
umartin commented on PR #772: URL: https://github.com/apache/sedona/pull/772#issuecomment-1435226458 I think there was a patch in a point release of Java 11 that changed the string representation of floats. For me it fails on Java 11.0.17 although I remember it passing on earlier version of

[GitHub] [sedona] jiayuasu commented on pull request #772: [SEDONA-249] Add jvm flags for running tests on Java 17

2023-02-17 Thread via GitHub
jiayuasu commented on PR #772: URL: https://github.com/apache/sedona/pull/772#issuecomment-1435176063 @umartin Thanks for bringing this up. Interestingly, I found CRSTransformationTest.testPolygonDistanceJoinWithCRSTransformation also failed on Java 11. I haven't figured why. Any idea? --

[jira] [Commented] (SEDONA-248) R – Let dev version of R package use SNAPSHOT jars

2023-02-17 Thread Jia Yu (Jira)
[ https://issues.apache.org/jira/browse/SEDONA-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690562#comment-17690562 ] Jia Yu commented on SEDONA-248: --- # Currently, the SNAPSHOT jar on Apache Maven repo has to

[GitHub] [sedona] umartin opened a new pull request, #772: [SEDONA-249] Add jvm flags for running tests on Java 17

2023-02-17 Thread via GitHub
umartin opened a new pull request, #772: URL: https://github.com/apache/sedona/pull/772 ## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apa

[jira] [Created] (SEDONA-249) Add jvm flags for running tests on Java 17

2023-02-17 Thread Martin Andersson (Jira)
Martin Andersson created SEDONA-249: --- Summary: Add jvm flags for running tests on Java 17 Key: SEDONA-249 URL: https://issues.apache.org/jira/browse/SEDONA-249 Project: Apache Sedona Issue

Re: [feature-request] ST_GEOHASH_COVER and ST_GEOHASH_COMPRESSION

2023-02-17 Thread Jia Yu
Hi George, H3 implementation is on our agenda. We will implement H3 once S2 is finished. Thanks, Jia On Fri, Feb 17, 2023 at 9:27 AM George Percivall wrote: > Jia, > > Is there an H3 implementation in Sedona? > > https://h3geo.org/ > https://github.com/uber/h3 > > George Percivall > GeoRoundta

Re: [feature-request] ST_GEOHASH_COVER and ST_GEOHASH_COMPRESSION

2023-02-17 Thread George Percivall
Jia, Is there an H3 implementation in Sedona? https://h3geo.org/ https://github.com/uber/h3 George Percivall GeoRoundtable.xyz perciv...@ieee.org > On Feb 17, 2023, at 12:16 PM, Jia Yu wrote: > > Hi, > > 1. I thi

[jira] [Commented] (SEDONA-244) Align R read/write functions with the Sparklyr framework

2023-02-17 Thread Jia Yu (Jira)
[ https://issues.apache.org/jira/browse/SEDONA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690512#comment-17690512 ] Jia Yu commented on SEDONA-244: --- [~gregleleu] Your suggestion makes perfect sense to me.  

Re: [feature-request] ST_GEOHASH_COVER and ST_GEOHASH_COMPRESSION

2023-02-17 Thread Jia Yu
Hi, 1. I think a single function st_geohashcover(geom, precision: optional) is good. If precision is not given, we generate geohash to a hard coded precision. A very common use case of GeoHash is to do spatial join. This requires that all geoms involved in the join follow the same geohash precisi

[jira] [Created] (SEDONA-248) R – Let dev version of R package use SNAPSHOT jars

2023-02-17 Thread Gregoire Leleu (Jira)
Gregoire Leleu created SEDONA-248: - Summary: R – Let dev version of R package use SNAPSHOT jars Key: SEDONA-248 URL: https://issues.apache.org/jira/browse/SEDONA-248 Project: Apache Sedona Is

[GitHub] [sedona] zongsizhang commented on a diff in pull request #764: [WIP] [SEDONA-235] Integrate S2, add ST_S2CellIDs

2023-02-17 Thread via GitHub
zongsizhang commented on code in PR #764: URL: https://github.com/apache/sedona/pull/764#discussion_r1110018835 ## docs/api/sql/Function.md: ## @@ -1536,3 +1536,20 @@ SELECT ST_ZMin(ST_GeomFromText('LINESTRING(1 3 4, 5 6 7)')) ``` Output: `4.0` + +## ST_S2CellIDs Review Co

[jira] [Created] (SEDONA-247) R copy_to/collect sf objects

2023-02-17 Thread Gregoire Leleu (Jira)
Gregoire Leleu created SEDONA-247: - Summary: R copy_to/collect sf objects Key: SEDONA-247 URL: https://issues.apache.org/jira/browse/SEDONA-247 Project: Apache Sedona Issue Type: New Feature

[GitHub] [sedona] zongsizhang commented on a diff in pull request #764: [WIP] [SEDONA-235] Integrate S2, add ST_S2CellIDs

2023-02-17 Thread via GitHub
zongsizhang commented on code in PR #764: URL: https://github.com/apache/sedona/pull/764#discussion_r1109851123 ## common/src/test/java/org/apache/sedona/common/FunctionsTest.java: ## @@ -238,4 +235,153 @@ public void splitHeterogeneousGeometryCollection() { assertNul