[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.

2021-05-21 Thread GitBox
Imbruced commented on a change in pull request #528: URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637163575 ## File path: sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala ## @@ -1122,4 +1123,48 @@ case class ST_FlipCoordina

[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.

2021-05-21 Thread GitBox
Imbruced commented on a change in pull request #528: URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637104231 ## File path: sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala ## @@ -1122,4 +1123,48 @@ case class ST_FlipCoordina

[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.

2021-05-21 Thread GitBox
Imbruced commented on a change in pull request #528: URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637103809 ## File path: sql/src/test/scala/org/apache/sedona/sql/functions/FunctionsHelper.scala ## @@ -0,0 +1,31 @@ +///* Review comment: ofc

[GitHub] [incubator-sedona] Imbruced commented on a change in pull request #528: [Sedona-27] Add ST_Subdivide and ST_SubdivideExplode functions.

2021-05-21 Thread GitBox
Imbruced commented on a change in pull request #528: URL: https://github.com/apache/incubator-sedona/pull/528#discussion_r637096112 ## File path: sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/subdivide/implicits.scala ## @@ -0,0 +1,28 @@ +/* + * Licensed to th