[GitHub] [sedona] jiayuasu commented on a diff in pull request #898: [SEDONA-323] Add keplergl wrapper

2023-07-17 Thread via GitHub
jiayuasu commented on code in PR #898: URL: https://github.com/apache/sedona/pull/898#discussion_r1266172498 ## docs/tutorial/sql.md: ## @@ -505,6 +505,81 @@ The details of a join query is available here [Join query](../api/sql/Optimizer. There are lots of other functions ca

[GitHub] [sedona] jiayuasu commented on a diff in pull request #898: [SEDONA-323] Add keplergl wrapper

2023-07-13 Thread via GitHub
jiayuasu commented on code in PR #898: URL: https://github.com/apache/sedona/pull/898#discussion_r1262197683 ## python/sedona/maps/SedonaKepler.py: ## @@ -0,0 +1,58 @@ +from keplergl import KeplerGl +import geopandas as gpd Review Comment: You introduced 4 new files in this

[GitHub] [sedona] jiayuasu commented on a diff in pull request #898: [SEDONA-323] Add keplergl wrapper

2023-07-12 Thread via GitHub
jiayuasu commented on code in PR #898: URL: https://github.com/apache/sedona/pull/898#discussion_r1262087459 ## python/tests/sql/test_sedonakepler_visualization.py: ## Review Comment: Please move this test to `python/tests/maps/` ## python/__init__.py: ##