-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46542/
-----------------------------------------------------------

(Updated April 29, 2016, 8:44 p.m.)


Review request for sentry, Hao Hao and Lenni Kuff.


Changes
-------

Addressed previous comments;
Added more validation to column level privileges and synced up acls;
Added negative test case;
Since they are boundary tests, splitted internal path tests and external path 
tests in different files; otherwise, test class runs long time.


Bugs: SENTRY-583
    https://issues.apache.org/jira/browse/SENTRY-583


Repository: sentry


Description
-------

Add one boundary HDFS SyncUp test to run on a real cluster;
Also add some basic APIs for createing more HDFS SyncUp tests.


Diffs (updated)
-----

  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestDbHdfsBase.java
 PRE-CREATION 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestDbHdfsExtMaxGroups.java
 PRE-CREATION 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestDbHdfsMaxGroups.java
 PRE-CREATION 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
 d2a1d36ee0572d5d24c200f631607e4cfa8168e3 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java
 8818c4c2b35b5a9979b7ca11a8a8548121bc348a 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/DFSFactory.java
 e1881b4bfaa5923fd0dab2096f670b22b944f116 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/MiniDFS.java
 77af4329642807283e6cd3d2e3be837c5d3e0dfb 

Diff: https://reviews.apache.org/r/46542/diff/


Testing
-------

Tested on a unmanaged real cluster.

--------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.sentry.tests.e2e.hdfs.TestDbHdfsMaxGroups
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.615 sec - in 
org.apache.sentry.tests.e2e.hdfs.TestDbHdfsMaxGroups

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Anne Yu

Reply via email to