Re: Review Request 49683: SENTRY-1347: Create performance test for show table

2016-07-05 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49683/ --- (Updated July 6, 2016, 2:39 a.m.) Review request for sentry and Hao Hao. Bugs

Review Request 49683: SENTRY-1347: Create performance test for show table

2016-07-05 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49683/ --- Review request for sentry and Hao Hao. Repository: sentry Description ---

Re: Review Request 49526: SENTRY-1365

2016-07-05 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49526/ --- (Updated July 5, 2016, 11:54 p.m.) Review request for sentry and Anne Yu. Rep

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

2016-07-05 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49397/ --- (Updated July 5, 2016, 11:42 p.m.) Review request for sentry, Anne Yu, Colin Mc

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-05 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/#review140875 --- Ship it! Ship It! - Hao Hao On July 5, 2016, 6:22 p.m., Srav

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-05 Thread Sravya Tirukkovalur
> On July 5, 2016, 6:47 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 114 > > > > > >

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-05 Thread Hao Hao
> On July 5, 2016, 6:47 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 376 > > > > > >

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-05 Thread Hao Hao
> On July 5, 2016, 6:47 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 114 > > > > > >

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-05 Thread Sravya Tirukkovalur
> On July 5, 2016, 6:47 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 55 > > > > > > TO

Re: Review Request 49643: SENTRY-1378: Made slight modifications

2016-07-05 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49643/#review140848 --- Ship it! Ship It! - Hao Hao On July 5, 2016, 5:15 p.m., Rahu

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-05 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/#review140845 --- Thanks Sravya! Left some more comments. sentry-tests/sentry-test

Re: Review Request 49643: SENTRY-1378: Made slight modifications

2016-07-05 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49643/#review140847 --- Ship it! Ship It! - Sravya Tirukkovalur On July 5, 2016, 5:1

Re: Review Request 49397: SENTRY-1329: Adapt SentryMetaStorePostEventListener to write HMS notification logs

2016-07-05 Thread Sravya Tirukkovalur
> On July 1, 2016, 12:52 a.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java, > > line 66 > > > > > > What if the notifi

Re: Review Request 49392: SENTRY-1324: Add sentry specific test cases to use NotificationLog using DbNotificationListener

2016-07-05 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/ --- (Updated July 5, 2016, 6:22 p.m.) Review request for sentry, Anne Yu, Colin McC

Review Request 49643: SENTRY-1378: Made slight modifications

2016-07-05 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49643/ --- Review request for sentry. Repository: sentry Description --- SENTRY-137