Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-25 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/ --- Review request for sentry, Anne Yu and Sravya Tirukkovalur. Repository: sentry

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-25 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/#review143423 --- Awesome work Rahul! Left minor comments. sentry-provider/sentry-

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-25 Thread Rahul Sharma
> On July 25, 2016, 8:37 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java, > > line 140 > > > > > > It is not clear to me what

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-25 Thread Sravya Tirukkovalur
> On July 25, 2016, 8:37 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java, > > line 140 > > > > > > It is not clear to me what

Re: Review Request 50404: SENTRY-1415: Provide a hook to stop the active sentry sevice

2016-07-25 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/ --- (Updated July 26, 2016, 12:18 a.m.) Review request for sentry, Anne Yu and Srav

Re: Review Request 50264: SENTRY-1331: Add a kerberos end to end test case to access isActive and isHa metrics.

2016-07-25 Thread Anne Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50264/#review143477 --- Ship it! Ship It! - Anne Yu On July 22, 2016, 8:36 p.m., Rah