Re: Review Request 53038: SENTRY-1507

2016-10-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53038/ --- (Updated Oct. 26, 2016, 7:04 a.m.) Review request for sentry, Colm O hEigeartai

Re: Review Request 53038: SENTRY-1507

2016-10-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53038/ --- (Updated Oct. 26, 2016, 7:03 a.m.) Review request for sentry, Colm O hEigeartai

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

2016-10-26 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/ --- (Updated Oct. 26, 2016, 8:04 a.m.) Review request for sentry. Repository: sen

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

2016-10-26 Thread Colin Ma
> On Oct. 26, 2016, 4:18 a.m., Alexander Kolbasov wrote: > > This is pretty big patch, it would be better to avoid unrelated changes > > mixed up. Thanks for the comments, will remove the unrelated changes for the transaction refactor. - Colin --

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

2016-10-26 Thread Colin Ma
> On Oct. 26, 2016, 4:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 262 > > > > > > Is this related on unrelated

Re: Review Request 53175: SENTRY-1501: Add option to use non pool model for sentry client

2016-10-26 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53175/#review153900 --- Ship it! Ship It! - Hao Hao On Oct. 26, 2016, 6:13 a.m., Li

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

2016-10-26 Thread Alexander Kolbasov
> On Oct. 26, 2016, 4:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java, > > line 107 > > > > > > Do you

Re: Review Request 53038: SENTRY-1507

2016-10-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53038/ --- (Updated Oct. 26, 2016, 7:13 p.m.) Review request for sentry, Colm O hEigeartai

Re: Review Request 53038: SENTRY-1507

2016-10-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53038/ --- (Updated Oct. 26, 2016, 7:22 p.m.) Review request for sentry, Colm O hEigeartai

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

2016-10-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153930 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 26, 2016, 8:0

Broken e2e tests in master?

2016-10-26 Thread Alexander Kolbasov
I was looking at test failures from my patch and the failures seem to be quite unrelated. A lot of e2e tests failed because there were too many failures like Unable to finalize edits file /tmp/1477513681071-0/dfs/name2/current/edits_inprogress_001 For example here you can see thes

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be reoved

2016-10-26 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52916/ --- (Updated Oct. 27, 2016, 12:16 a.m.) Review request for sentry, Colm O hEigearta

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

2016-10-26 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153970 --- Ship it! Ship It! - Hao Hao On Oct. 26, 2016, 8:04 a.m., Col