Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

2016-11-03 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52526/#review154867 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

2016-11-03 Thread Li Li
> On Nov. 3, 2016, 9:59 p.m., Hao Hao wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java, > > line 88 > > > > > > Make it v

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

2016-11-03 Thread Alexander Kolbasov
> On Nov. 3, 2016, 9:59 p.m., Hao Hao wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java, > > line 88 > > > > > > Make it v

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

2016-11-03 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52916/#review154821 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

2016-11-03 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52916/#review154809 --- LGTM. fix it and ship it sentry-service/sentry-service-server/sr

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

2016-11-03 Thread Alexander Kolbasov
> On Nov. 3, 2016, 7:02 a.m., Colin Ma wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java, > > line 39 > > > > > > Do we still

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

2016-11-03 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52916/#review154680 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen