Re: [DISCUSS] Sentry interactive shell

2016-12-14 Thread Alexander Kolbasov
> On Dec 14, 2016, at 8:46 PM, Lenni Kuff wrote: > > Thanks for kicking this off Sasha. IMO, a robust Sentry CLI seems super > important for the project - especially as Sentry support for more > components comes online. It also helps to allow 3rd party integration with >

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/#review159252 --- It seems like you have the wrong diff here - you should have

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread Alexander Kolbasov
> On Dec. 6, 2016, 10:40 p.m., Vadim Spector wrote: > > sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java, > > line 1031 > > > > > >

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-14 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/ --- (Updated Dec. 14, 2016, 11:57 p.m.) Review request for sentry, Colin Ma, Hao

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-14 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review159250 ---

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/#review159246 ---

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-14 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated Dec. 14, 2016, 10:38 p.m.) Review request for sentry, Alexander

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

2016-12-14 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review159242 --- Ship it! Ship It! - Vamsee Yarlagadda On Dec. 7, 2016,

Re: Review Request 54409: SENTRY-1476: SentryStore is subject to JDQL injection

2016-12-14 Thread Alexander Kolbasov
> On Dec. 14, 2016, 9:26 p.m., Vamsee Yarlagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > lines 2647-2654 > > > > > >

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2016-12-14 Thread kalyan kumar kalvagadda
> On Dec. 7, 2016, 12:56 a.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1431 > > > > > > Why do

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/ --- (Updated Dec. 14, 2016, 10:23 p.m.) Review request for sentry, Alexander

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/ --- (Updated Dec. 14, 2016, 10:11 p.m.) Review request for sentry, Alexander

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

2016-12-14 Thread kalyan kumar kalvagadda
> On Dec. 6, 2016, 10:40 p.m., Vadim Spector wrote: > > sentry-service/sentry-service-common/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java, > > line 1031 > > > > > >

Re: Review Request 54409: SENTRY-1476: SentryStore is subject to JDQL injection

2016-12-14 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54409/#review159226 ---

Re: Review Request 54697: SENTRY-1513: Changed the way the split works when parsing a path and corrected spelling in PathsUpdate

2016-12-14 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54697/#review159178 --- Ship it! Ship It! - Alexander Kolbasov On Dec. 13, 2016,