Re: Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-15 Thread Misha Dmitriev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/#review159415 --- Ship it! Ship It! - Misha Dmitriev On Dec. 16, 2016, 7:23 a.

Review Request 54808: SENTRY-1526 Sentry processed stays alive after being killed

2016-12-15 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54808/ --- Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda,

Review Request 54798: SENTRY-1546 Generic Policy provides bad error messages for Sentry exceptions

2016-12-15 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54798/ --- Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and V

Re: Review Request 54525: SENTRY-1541: toSentryPrivilege() should not copy fields that are not set in the source

2016-12-15 Thread Vamsee Yarlagadda
> On Dec. 13, 2016, 6:28 p.m., Alexander Kolbasov wrote: > > 1) Do we have any other users of fromNullCol or it should be removed as > > well? > > 2) This relates to SENTRY-1540 since now isMultiActionsSupported() becomes > > a real code and this changes the existing semantics some. Is it Ok or