Re: Review Request 55094: SENTRY-1532: Sentry Web UI isn't working

2017-01-03 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55094/#review160457 --- sentry-tests/sentry-tests-solr/pom.xml (line 58)

Re: Review Request 55094: SENTRY-1532: Sentry Web UI isn't working

2017-01-03 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55094/ --- (Updated Jan. 4, 2017, 12:31 a.m.) Review request for sentry, Colm O hEigeartai

[DISCUSS] Problem with existing Sentry e2e tests

2017-01-03 Thread Alexander Kolbasov
I think we have a problem with the way e2e tests are currently structured. They run all components in a single JVM - a setup that is never used in practice. As a result, this creates a lot of potential for breaking things due to various library version issues. I've seen a few cases where reasonable

Sentry-jdk-1.7-v2 - Build # 50 - Failure

2017-01-03 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #50) Status: Failure Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/50/ to view the results.

Re: Review Request 55080: SENTRY-1428: Only leader should follow HMS updates

2017-01-03 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55080/#review160431 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review160430 --- Ship it! Ship It! - Alexander Kolbasov On Jan. 3, 2017, 8:15

Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Jan. 3, 2017, 8:15 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review160429 --- Fix it, then Ship it! sentry-service/sentry-service-server/src

Re: Review Request 55080: SENTRY-1428: Only leader should follow HMS updates

2017-01-03 Thread Misha Dmitriev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55080/#review160427 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Jan. 3, 2017, 8:02 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review160428 --- Fix it, then Ship it! A few nits, otherwise good comments. se

Re: Review Request 54525: SENTRY-1541/SENTRY-1582: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Jan. 3, 2017, 7:46 p.m.) Review request for sentry, Alexander Kolbasov

Re: Review Request 54525: SENTRY-1541: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review160425 --- Ship it! Ship It! - Hao Hao On Jan. 3, 2017, 7:13 p.m., Vams

Re: Review Request 54525: SENTRY-1541: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/#review160422 --- Ship it! Ship It! - kalyan kumar kalvagadda On Jan. 3, 2017,

Re: Review Request 54525: SENTRY-1541: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Vamsee Yarlagadda
> On Dec. 16, 2016, 10:18 p.m., kalyan kumar kalvagadda wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1644 > > > > > > I'm

Re: Review Request 54525: SENTRY-1541: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Vamsee Yarlagadda
> On Dec. 19, 2016, 8:15 p.m., Hao Hao wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1720 > > > > > > It looks like fromNU

Re: Review Request 54525: SENTRY-1541: Additional comments to clarify the intent of string manipulation methods in SentryStore.java

2017-01-03 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54525/ --- (Updated Jan. 3, 2017, 7:13 p.m.) Review request for sentry, Alexander Kolbasov