Sentry-jdk-1.7-v2 - Build # 53 - Fixed

The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #53) Status: Fixed Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/53/ to view the results.

Sentry-jdk-1.7 - Build # 752 - Failure

The Apache Jenkins build system has built Sentry-jdk-1.7 (build #752) Status: Failure Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/752/ to view the results.

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55246/ --- (Updated Jan. 10, 2017, 2:31 a.m.) Review request for sentry, Alexander

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

> On Jan. 6, 2017, 9:41 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 453 > > > > > >

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

> On Jan. 6, 2017, 9:41 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 452 > > > > > > If HMS follower just

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54729/ --- (Updated Jan. 10, 2017, 1:57 a.m.) Review request for sentry, Alexander

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

> On Jan. 6, 2017, 10:28 p.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java, > > lines 73-87 > > > > > > Just

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

> On Jan. 6, 2017, 9:38 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPathChange.java, > > line 82 > > > > > > What is the

Re: Review Request 54729: SENTRY-1538: Create schema for storing HMS path change and Sentry permission change.

> On Jan. 6, 2017, 9:38 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java, > > line 161 > > > > > > Okease add javadocs for the new functions

Sentry-jdk-1.7 - Build # 751 - Unstable

The Apache Jenkins build system has built Sentry-jdk-1.7 (build #751) Status: Unstable Check console output at https://builds.apache.org/job/Sentry-jdk-1.7/751/ to view the results.

Re: Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52795/ --- (Updated Jan. 10, 2017, 12:01 a.m.) Review request for sentry, Alexander

Re: Review Request 52795: SENTRY-1499: Add feature flag for using NotificationLog

> On Jan. 6, 2017, 10:08 p.m., Vamsee Yarlagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java, > > lines 160-167 > > > > > >

Sentry-jdk-1.7-v2 - Build # 52 - Still Failing

The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #52) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/52/ to view the results.

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

> On Jan. 5, 2017, 3:49 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1624 > > > > > > Do you know why

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

> On Jan. 5, 2017, 3:49 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1624 > > > > > > Do you know why

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

> On Jan. 5, 2017, 3:49 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 1624 > > > > > > Do you know why

Re: Review Request 53920: SENTRY-1534: Oracle supports serializable instead of repeatable-read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53920/#review160957 --- Ship it! Ship It! - Hao Hao On Jan. 5, 2017, 9:04 a.m.,

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review160952 --- Ship it! - Hao Hao On Jan. 5, 2017, 8:28 p.m., Alexander

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54526/ --- (Updated Jan. 9, 2017, 8:15 p.m.) Review request for sentry, Alexander

Re: Review Request 54526: SENTRY-1540: SentryStore.isMultiActionsSupported() is always true

> On Jan. 9, 2017, 6:27 p.m., Mat Crocker wrote: > > should your || be an && ? > > this logic suggests its ok if the db is null, but the table name isn't The comment for this function says: "// Currently INSERT/SELECT/ALL are supported for Table and DB level privileges" So if the privilege

Re: Review Request 55094: SENTRY-1532: Sentry Web UI isn't working

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55094/#review160950 --- Fix it, then Ship it! sentry-tests/sentry-tests-solr/pom.xml

Re: Review Request 55094: SENTRY-1532: Sentry Web UI isn't working

> On Jan. 9, 2017, 6:22 p.m., Mat Crocker wrote: > > was the Web UI actually started and smoke tested, or just a unit test fix ? I actually started it and accessed all entry points. Without the fix you can't use it. - Alexander ---

Re: Review Request 54338: SENTRY-1515: Cleanup exception handling in SentryStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54338/#review160923 --- Ship it! looks like basic try/catch clean up, looks good to

Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad error messages for Sentry exceptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54798/#review160921 --- agreed with Vamsee, it needs a trimmedNamed + "_Already Exists"

Re: Review Request 55094: SENTRY-1532: Sentry Web UI isn't working

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55094/#review160918 --- was the Web UI actually started and smoke tested, or just a unit

Re: Review Request 54445: SENTRY-1547 - It is possible to create a privilege with all empty fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54445/#review160917 --- minor nit, should be labeled "fields" not "feilds" Looks like