[DISCUSS] Extending Sentry protocol

2017-02-07 Thread Alexander Kolbasov
Hello everyone, I would like to extend the Hive-to-Sentry API with a new call needed to synchronize between Hive operations and async Hive notification processing by Sentry. I would like to do it without incrementing the version number - do you think that it is reasonable, or *any* API changes req

Re: Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl

2017-02-07 Thread Nachiket Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56411/#review164632 --- Ship it! Thank you for changes. - Nachiket Vaidya On Feb. 8,

Re: Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl

2017-02-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56411/ --- (Updated Feb. 8, 2017, 5:15 a.m.) Review request for sentry, Aihua Xu, Hao Hao,

Re: Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl

2017-02-07 Thread Alexander Kolbasov
> On Feb. 7, 2017, 11:01 p.m., Nachiket Vaidya wrote: > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java, > > line 212 > > > > > > Is sen

Re: Review Request 56000: SENTRY-1604 Sentry JSON message factory: Need more information in alter partition event

2017-02-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56000/#review164613 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 4, 2017, 5:48

Re: Review Request 56403: SENTRY-1387 Add HDFS sync tests for drop partition for external/implicit locations

2017-02-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56403/#review164612 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 7, 2017, 8:54

Sentry-jdk-1.7-v2 - Build # 61 - Still Failing

2017-02-07 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #61) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/61/ to view the results.

Re: Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl

2017-02-07 Thread Nachiket Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56411/#review164577 --- sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/se

Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl

2017-02-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56411/ --- Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Nachiket Vaidya, an

Re: Review Request 56356: SENTRY-1615 SentryStore should not allocate empty objects that are immediately returned

2017-02-07 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56356/#review164566 --- Ship it! Ship It! - Vadim Spector On Feb. 7, 2017, 2:14 a.m.

Re: Review Request 56095: HIVE-15754 exchange partition is not generating notifications

2017-02-07 Thread Nachiket Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56095/ --- (Updated Feb. 7, 2017, 9:32 p.m.) Review request for sentry and Mohit Sabharwal

Re: Review Request 56356: SENTRY-1615 SentryStore should not allocate empty objects that are immediately returned

2017-02-07 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56356/#review164560 --- Ship it! Ship It! - Vamsee Yarlagadda On Feb. 7, 2017, 2:14

Review Request 56403: SENTRY-1387 Add HDFS sync tests for drop partition for external/implicit locations

2017-02-07 Thread Nachiket Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56403/ --- Review request for sentry, Alexander Kolbasov, Hao Hao, and Vamsee Yarlagadda.

Sentry-jdk-1.7-v2 - Build # 60 - Still Failing

2017-02-07 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #60) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/60/ to view the results.

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

2017-02-07 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/#review164454 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 56134: SENTRY-1593 Implementing client failover for Generic policy clients and namenode clients

2017-02-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56134/#review164470 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/Se

Re: Review Request 56134: SENTRY-1593 Implementing client failover for Generic policy clients and namenode clients

2017-02-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56134/#review164469 --- sentry-core/sentry-core-common/src/main/java/org/apache/sentry/co

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

2017-02-07 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/#review164467 --- sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hd