Review Request 57266: SENTRY-1642 Integrate Sentry build with Error Prone

2017-03-02 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57266/ --- Review request for sentry, Lei Xu, Hao Hao, kalyan kumar kalvagadda, Mat Crocker

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-02 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review167795 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-02 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/ --- (Updated March 3, 2017, 3:08 a.m.) Review request for sentry, Misha Dmitriev, L

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-02 Thread Alexander Kolbasov
> On March 3, 2017, 1:20 a.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java > > Lines 137 (patched) > > > > > > Hmm ... imagine the follo

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-02 Thread Alexander Kolbasov
> On March 3, 2017, 1:20 a.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java > > Lines 137 (patched) > > > > > > Hmm ... imagine the follo

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-02 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/#review167778 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-02 Thread Alexander Kolbasov
> On March 2, 2017, 11:56 p.m., Vadim Spector wrote: > > Could you, please, add a short description of HMS Notification barrier's > > purpose? I attached sequence diagrams to SENTRY-1601 to demonstrate the problem and the solution. - Alexander --

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-02 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/#review167766 --- Could you, please, add a short description of HMS Notification bar

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

2017-03-02 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55706/ --- (Updated March 2, 2017, 9:43 p.m.) Review request for sentry. Repository: sen

Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table to add a column for notification ID

2017-03-02 Thread kalyan kumar kalvagadda
> On March 2, 2017, 5:40 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Lines 287 (patched) > > > > > > SENTRY-16

Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table to add a column for notification ID

2017-03-02 Thread Lei Xu
> On March 2, 2017, 9:40 a.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Lines 287 (patched) > > > > > > SENTRY-16

Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table to add a column for notification ID

2017-03-02 Thread kalyan kumar kalvagadda
> On March 2, 2017, 5:40 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Lines 287 (patched) > > > > > > SENTRY-16

Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table to add a column for notification ID

2017-03-02 Thread Lei Xu
> On March 2, 2017, 9:40 a.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > > Lines 287 (patched) > > > > > > SENTRY-16

Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table to add a column for notification ID

2017-03-02 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57220/#review167691 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 54947: SENTRY-1556 Simplify privilege cleaning

2017-03-02 Thread kalyan kumar kalvagadda
> On Feb. 28, 2017, 7:35 a.m., Alexander Kolbasov wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > > Lines 139 (patched) > > > > > > It is a

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-02 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated March 2, 2017, 2:44 p.m.) Review request for sentry, Alexander Kolbaso