Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread Alexander Kolbasov
> On March 3, 2017, 9:58 p.m., Lei Xu wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java > > Lines 99 (patched) > > > > > > should it be "newValue <=

Sentry-jdk-1.7-v2 - Build # 67 - Failure

2017-03-03 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #67) Status: Failure Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/67/ to view the results.

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/ --- (Updated March 4, 2017, 1:34 a.m.) Review request for sentry, Misha Dmitriev,

Re: Review Request 54947: SENTRY-1556 Simplify privilege cleaning

2017-03-03 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54947/ --- (Updated March 4, 2017, 12:40 a.m.) Review request for sentry, Alexander

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/#review167893 --- Ship it! The last comments are not critical, so leaving

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/#review167888 ---

Re: Review Request 57308: SENTRY-1388: Make HiveConf and Hive client jars available to Sentry deamon

2017-03-03 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57308/ --- (Updated March 3, 2017, 10:41 p.m.) Review request for sentry, Alexander

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread Vadim Spector
> On March 3, 2017, 10:13 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestCounterWait.java > > Lines 55 (patched) > > > > > > The way inSyncQueue

Review Request 57308: SENTRY-1388: Make HiveConf and Hive client jars available to Sentry deamon

2017-03-03 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57308/ --- Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar

Re: Review Request 57266: SENTRY-1642 Integrate Sentry build with Error Prone

2017-03-03 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57266/#review167877 --- Ship it! Ship It! - Lei Xu On March 2, 2017, 10:29 p.m.,

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/#review167867 ---

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread kalyan kumar kalvagadda
> On March 3, 2017, 9:53 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java > > Lines 175 (patched) > > > > > > We are in the

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread Vadim Spector
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/#review167869 ---

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-03 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated March 3, 2017, 9:04 p.m.) Review request for sentry, Alexander

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

2017-03-03 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/#review167865 ---

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-03 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/#review167848 --- Fix it, then Ship it! Ship It!

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

2017-03-03 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54454/ --- (Updated March 3, 2017, 4:41 p.m.) Review request for sentry, Alexander