Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-14 Thread Hao Hao
> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 30 (patched) > > > > > > The first sentence should b

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-14 Thread Hao Hao
> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3298 (patched) > > > > > >

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-14 Thread Hao Hao
> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3406 (patched) > > > > > >

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-14 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 14, 2017, 6:59 p.m.) Review request for sentry. Repository: se

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-14 Thread Hao Hao
> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 59 (patched) > > > > > > Can we relax the return typ

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-14 Thread Hao Hao
> On March 14, 2017, 12:48 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > > Lines 77 (patched) > > > > > > Why are we using a new loc

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

2017-03-14 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review168939 --- Can you add test cases in the intergation test as well, TestHDFSI

Re: Review Request 57232: SENTRY-1613: Add propagating logic for Perm/Path updates in Sentry service

2017-03-14 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57232/ --- (Updated March 14, 2017, 8:56 p.m.) Review request for sentry. Repository: se