Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184628 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Sentry-jdk-1.7-v2 - Build # 138 - Still Failing

2017-09-05 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #138) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/138/ to view the results.

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Brian Towles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 5, 2017, 9:25 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Brian Towles
> On Sept. 5, 2017, 9:02 p.m., Vamsee Yarlagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Line 115 (original), 122 (patched) > > > > > > What would pr

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Brian Towles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 5, 2017, 9:25 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Brian Towles
> On Sept. 5, 2017, 8:21 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 81 (patched) > > > > > > Are you sure you get your boo

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184619 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 62101: SENTRY-1916 Sentry should not store paths outside of the prefix

2017-09-05 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62101/#review184614 --- Ship it! Ship It! - Vamsee Yarlagadda On Sept. 6, 2017, 12:5

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/#review184613 --- sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/h

Re: Review Request 62101: SENTRY-1916 Sentry should not store paths outside of the prefix

2017-09-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62101/ --- (Updated Sept. 6, 2017, 12:54 a.m.) Review request for sentry, Arjun Mishra, Br

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Brian Towles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 5, 2017, 7:42 p.m.) Review request for sentry, Alexander Kolbaso

Re: Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Brian Towles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- (Updated Sept. 5, 2017, 7:41 p.m.) Review request for sentry, Alexander Kolbaso

Review Request 62107: SENTRY-1918: NN snapshot should not be served while HMS snapshot is collected

2017-09-05 Thread Brian Towles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62107/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, Na Li, Sergio Pena,

Review Request 62101: SENTRY-1916 Sentry should not store paths outside of the prefix

2017-09-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62101/ --- Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, and V

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Vamsee Yarlagadda
> On Sept. 5, 2017, 9:44 p.m., Vamsee Yarlagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > > Lines 103 (patched) > > > > > > At this point, we d

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Vamsee Yarlagadda
> On Sept. 5, 2017, 10:28 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > > Lines 46 (patched) > > > > > > I think it is a bit

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62096/ --- (Updated Sept. 5, 2017, 10:41 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62096/#review184595 --- Fix it, then Ship it! Ship It! sentry-hdfs/sentry-hdfs-servic

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Sergio Pena
> On Sept. 5, 2017, 9:44 p.m., Vamsee Yarlagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > > Lines 103 (patched) > > > > > > At this point, we d

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Vamsee Yarlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62096/#review184587 --- LGTM Otherwise sentry-hdfs/sentry-hdfs-service/src/main/java/org

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Sergio Pena
> On Sept. 5, 2017, 9:28 p.m., Na Li wrote: > > have you checked if unit tests work with this behavior change? Testing is in progress. - Sergio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62096/#review184585 --- have you checked if unit tests work with this behavior change? -

Re: Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62096/#review184584 --- Ship it! Ship It! - Na Li On Sept. 5, 2017, 9:11 p.m., Sergi

Review Request 62096: SENTRY-1919: Sentry should prevent two snapshots from being sent to HDFS

2017-09-05 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62096/ --- Review request for sentry, Alexander Kolbasov, Brian Towles, Na Li, and Vamsee Y

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving roles for groups

2017-09-05 Thread Arjun Mishra
> On Sept. 1, 2017, 6:07 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 1811 (original), 1811 (patched) > >

Sentry-jdk-1.7-v2 - Build # 137 - Still Failing

2017-09-05 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.7-v2 (build #137) Status: Still Failing Check console output at https://builds.apache.org/job/Sentry-jdk-1.7-v2/137/ to view the results.