Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-23 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196083 --- Ship it! Ship It! - Vadim Spector On Jan. 23, 2018, 11:40 p.

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-23 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/ --- (Updated Jan. 23, 2018, 11:40 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-23 Thread Vadim Spector via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196078 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-23 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196076 --- Ship it! Ship It! - Na Li On Jan. 23, 2018, 6:43 p.m., kalya

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-23 Thread Vadim Spector via Review Board
> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Lines 67 (patched) > > > > > > I wonder about

Re: Review Request 64955: SENTRY-2109: Fix the logic of identifying HMS out of Sync

2018-01-23 Thread kalyan kumar kalvagadda via Review Board
> On Jan. 22, 2018, 8:49 p.m., Vadim Spector wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java > > Line 60 (original), 61 (patched) > > > > > >

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

2018-01-23 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/ --- (Updated Jan. 23, 2018, 6:43 p.m.) Review request for sentry, Arjun Mishra, Na

Re: Review Request 65244: SENTRY-2074: Fix maven dependencies to have all directly used libraries defined

2018-01-23 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65244/#review196040 --- Thanks for the explanation - I see the dependency list is greatly