Re: Review Request 65816: SENTRY-2145 - Some misc code cleanups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65816/#review200047 --- Ship it! Changes look good to me. - Sergio Pena On Feb. 28,

Re: Review Request 65953: SENTRY-2165: NotificationProcesser process notification methods have logs wrongly flagged as ERROR

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65953/#review200048 --- Ship it! Thanks Arjun, I've seen this error messages causing so

Re: Hive changes to object ownership

Thanks for the info. Those changes do not apply to Sentry because that is authorization metadata stored in HMS which Sentry does not consume at all. I initially was looking into those objects, though, but I found that those privileges must be set by the HMS clients in order to work. Also, I think

Re: Alternative Sentry architecture

The idea looks interesting. So, we have the following hooks or plugins in HMS for dealing with authorization: - A MetastoreAuthzBinding hook which enforces HMS authorization. - A SentryJSONMessageFactory which works with DbNotificationListener to generate correct event messages. - A Se

Separating thrift api out (SENTRY-2188)

Hey all, I’ve started writing some skeleton apis for ABAC. In the process, I’ve had to regenerate the Thrift api. Anytime that happens, it regenerates all the files and gives it a new timestamp. So when I look in git, it shows 75+ files have changed in addition to my new set of apis. I then

Re: Separating thrift api out (SENTRY-2188)

Thanks Stephen for stepping into this issue. I've seen this issue before and it is tedious to manually roll back each file. But because I don't generate thrift sources too often, then I didn't care at that time. Anyway, thrift apis are in source control to the time generating them in every compil

Re: Separating thrift api out (SENTRY-2188)

Looks like it about 5 seconds. org.apache.thrift.tools:maven-thrift-plugin > On Mar 27, 2018, at 3:27 PM, Sergio Pena wrote: > > Thanks Stephen for stepping into this issue. I've seen this issue before > and it is tedious to manually roll back each file. But because I don't > generate thrift s

Review Request 66319: 75+ files are uneccessarily changed when generetating new Thrift files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66319/ --- Review request for sentry. Repository: sentry Description --- Changed th

Re: Separating thrift api out (SENTRY-2188)

I have some concerns there. It is, indeed, a problem every time you need to do thrift changes, but so fat this was usually a rare event. Having thrift as a requirement makes life inconvenient - for example the thrift version that I have on my laptop is 0.11.0 and I have to do something special to g