Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

2018-05-09 Thread Na Li via Review Board
> On May 10, 2018, 2:17 a.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > > Lines 123 (patched) > > > > > > Are roles wit

Re: Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

2018-05-09 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67046/#review202818 --- sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentr

Review Request 67046: SENTRY-2226: Support Hive operation ALTER TABLE EXCHANGE

2018-05-09 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67046/ --- Review request for sentry. Bugs: sentry-2226 https://issues.apache.org/jira

Sentry-jdk-1.8 - Build # 28 - Fixed

2018-05-09 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.8 (build #28) Status: Fixed Check console output at https://builds.apache.org/job/Sentry-jdk-1.8/28/ to view the results.

Sentry-jdk-1.8 - Build # 27 - Failure

2018-05-09 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.8 (build #27) Status: Failure Check console output at https://builds.apache.org/job/Sentry-jdk-1.8/27/ to view the results.

Re: Review Request 66888: SENTRY-2206 Refactor out sentry api from sentry-provider-db to own module

2018-05-09 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66888/#review202795 --- Ship it! Thanks Steve. The patch looks good. I checked the rena

Re: Review Request 66888: SENTRY-2206 Refactor out sentry api from sentry-provider-db to own module

2018-05-09 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66888/ --- (Updated May 9, 2018, 8:12 p.m.) Review request for sentry. Repository: sentr

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

2018-05-09 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/#review202791 --- Ship it! Ship It! - Sergio Pena On May 9, 2018, 7:13 p.m., k

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

2018-05-09 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/#review202789 --- Ship it! Ship It! - Na Li On May 9, 2018, 7:13 p.m., kalyan

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

2018-05-09 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/ --- (Updated May 9, 2018, 7:13 p.m.) Review request for sentry, Na Li and Sergio Pe

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

2018-05-09 Thread Na Li via Review Board
> On May 8, 2018, 8:57 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 31 (original), 33 (patched) > > > > > > Can you add comment sa

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

2018-05-09 Thread kalyan kumar kalvagadda via Review Board
> On May 8, 2018, 8:57 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 31 (original), 33 (patched) > > > > > > Can you add comment sa

Re: Review Request 66265: SENTRY-2155: Update JDO to grant privileges to user

2018-05-09 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66265/#review202768 --- Ship it! Ship It! - Sergio Pena On May 9, 2018, 4:25 p.m., N

Re: Review Request 66265: SENTRY-2155: Update JDO to grant privileges to user

2018-05-09 Thread Na Li via Review Board
> On May 9, 2018, 12:13 a.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > > Lines 40 (patched) > > > > > > Shouldn't this comm

Re: Review Request 66265: SENTRY-2155: Update JDO to grant privileges to user

2018-05-09 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66265/ --- (Updated May 9, 2018, 4:25 p.m.) Review request for sentry, Alexander Kolbasov,

Re: Review Request 67006: SENTRY-2173: Extend PrivilegeInfo to hold user privileges

2018-05-09 Thread kalyan kumar kalvagadda via Review Board
> On May 8, 2018, 7:52 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 27 (original), 29 (patched) > > > > > > I think we shoul

Re: Review Request 66972: SENTRY-2219: Create index AUTHZ_PATH_FK_IDX at table AUTHZ_PATH only when it does not exist for Oracle

2018-05-09 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66972/#review202752 --- Ship it! Ship It! - Arjun Mishra On May 8, 2018, 6:52 p.m.,