Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67134/ --- (Updated May 17, 2018, 4:46 a.m.) Review request for sentry, kalyan kumar kalva

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/ --- (Updated May 17, 2018, 1:28 a.m.) Review request for sentry, Alexander Kolbasov

Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/ --- Review request for sentry, Alexander Kolbasov, Arjun Mishra, kalyan kumar kalvag

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 15, 2018, 9:37 p.m., Sergio Pena wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 1595 (original), 1595 (patched) > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 15, 2018, 9:37 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > > Lines 31-142 (original), 32-145 (patched) > > > > > >

Re: Review Request 67134: SENTRY-2224: Support SHOW GRANT on HIVE_OBJECT

> On May 15, 2018, 9:37 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 209 (patched) > > > > > > If it

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/#review203285 --- Ship it! Ship It! - Na Li On May 16, 2018, 6:41 p.m., kalyan

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

> On May 16, 2018, 3:52 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Lines 278 (patched) > > > > > > Is it abnormal for this to happen

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/ --- (Updated May 16, 2018, 6:41 p.m.) Review request for sentry, Arjun Mishra, Na L

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

> On May 16, 2018, 4:46 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Lines 99-101 (original), 99-101 (patched) > > > > > > This

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

> On May 16, 2018, 3:52 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Lines 288 (patched) > > > > > > why should this be FsAction.NONE

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/#review203240 --- sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

> On May 16, 2018, 3:52 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Lines 245 (patched) > > > > > > should you check the type if user

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/#review203235 --- sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/