Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 2:45 p.m., Arjun Mishra wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > > Lines 253 (patched) > > > > > > Can we also have a type

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203371 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/ --- (Updated May 17, 2018, 9:41 p.m.) Review request for sentry, Alexander

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 9:40 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java > > Lines 303 (patched) > > > > > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 4:06 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 169-173 (original), 171-178 (patched) > >

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 12:36 p.m., kalyan kumar kalvagadda wrote: > > In general note can't you seperate patches for below? > > 1.Add functions related to grant/revoke privileges to/from user > > 2.Fix the bugs related to grant/revoke partial privileges. They are caused > > by adding fine grained

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

> On May 17, 2018, 2:45 p.m., Arjun Mishra wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > > Lines 253 (patched) > > > > > > Can we also have a type

Re: Review Request 67180: SENTRY-2235: Add hive tests to verify column privileges for views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67180/#review203365 ---

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67093/#review203363 --- Can't we tease apart that database models and possibly JPA layer

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67093/#review203362 ---

Re: Review Request 67180: SENTRY-2235: Add hive tests to verify column privileges for views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67180/#review203348 --- Ship it! Ship It! - Sergio Pena On May 17, 2018, 12:21

Re: Review Request 67131: SENTRY-2174: Sentry authorization provider should now generate ACL for users

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67131/#review203347 --- Ship it! Ship It! - Sergio Pena On May 16, 2018, 6:41 p.m.,

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203329 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203312 ---

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203327 --- In general note can't you seperate patches for below? 1.Add

Review Request 67180: SENTRY-2235: Add hive tests to verify column privileges for views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67180/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2235

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67174/#review203319 ---