Re: Review Request 67695: SENTRY-2277: Add to SentryStore testURI test case testing with multiple URI privileges

> On June 21, 2018, 10:16 p.m., kalyan kumar kalvagadda wrote: > > Arjun, > > > > Can you explian what was wrong with old test case? The test case has been changeed to include a new role, role2, and a new uri privilege granted to this role. If we were to set active role set as both role1 and

Re: Review Request 67695: SENTRY-2277: Add to SentryStore testURI test case testing with multiple URI privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67695/#review205212 --- Arjun, Can you explian what was wrong with old test case? - kaly

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67648/ --- (Updated June 21, 2018, 9:28 p.m.) Review request for sentry, Arjun Mishra, Na

Review Request 67695: SENTRY-2277: Add to SentryStore testURI test case testing with multiple URI privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67695/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Repository:

Re: Review Request 67649: SENTRY-2274: Grant and revoke owner privileges based on HMS updates(server-side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67649/#review205209 --- Ship it! Ship It! - Sergio Pena On June 21, 2018, 5:42 p.m.,

Re: Review Request 67690: SENTRY-2231: Fix URI check on List Privileges by Provider in SentryStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67690/#review205206 --- Code change looks good. API "getMSentryPrivileges" which is been f

Re: Review Request 67691: SENTRY-2209: Incorrect class in SentryHdfsMetricsUtil.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67691/#review205201 --- Ship it! Looks Good. - kalyan kumar kalvagadda On June 21, 2

Re: Review Request 67649: SENTRY-2274: Grant and revoke owner privileges based on HMS updates(server-side)

> On June 19, 2018, 10:38 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 1453 (patched) > > > > > > 'hi

Re: Review Request 67649: SENTRY-2274: Grant and revoke owner privileges based on HMS updates(server-side)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67649/ --- (Updated June 21, 2018, 5:42 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67646/#review205186 --- Ship it! Ship It! - Arjun Mishra On June 19, 2018, 3:25 p.m.

Re: Review Request 67646: SENTRY-2272: Fix the sentry store logic for listing user privileges

> On June 20, 2018, 4:04 p.m., Arjun Mishra wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 235 (patched) > > > > > > Shou

Re: Review Request 67690: SENTRY-2231: Fix URI check on List Privileges by Provider in SentryStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67690/#review205181 --- Ship it! Looks good. I see this same filter is used on getMSent

Re: Review Request 67692: SENTRY-2199: Bump Hive version from 2.3.2 to 2.3.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67692/#review205179 --- Ship it! Ship It! - Sergio Pena On June 21, 2018, 3:47 p.m.,

Review Request 67692: SENTRY-2199: Bump Hive version from 2.3.2 to 2.3.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67692/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Repository:

Review Request 67691: SENTRY-2209: Incorrect class in SentryHdfsMetricsUtil.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67691/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Repository:

Review Request 67690: SENTRY-2231: Fix URI check on List Privileges by Provider in SentryStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67690/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Repository:

Re: Review Request 67648: SENTRY-2251: Update user privileges based on changes to authorizables

> On June 20, 2018, 3:16 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 1123-1127 (original), 1124-1127 (patched) > >