Re: Review Request 67539: SENTRY-2264: It is possible to elevate privileges from DROP using alter table rename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67539/ --- (Updated June 26, 2018, 4:36 a.m.) Review request for sentry, kalyan kumar kalv

Re: Review Request 67539: SENTRY-2264: It is possible to elevate privileges from DROP using alter table rename

> On June 12, 2018, 4:27 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > > Line 110 (original), 110-111 (patched) > >

Re: Review Request 67539: SENTRY-2264: It is possible to elevate privileges from DROP using alter table rename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67539/ --- (Updated June 26, 2018, 4:22 a.m.) Review request for sentry, kalyan kumar kalv

Re: Review Request 67218: SENTRY-2238: Explicitly set Database on SentryHivePrivilegeObjectDesc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67218/#review205341 --- Ship it! Ship It! - Na Li On June 26, 2018, 12:18 a.m., Arju

Re: Review Request 67218: SENTRY-2238: Explicitly set Database on SentryHivePrivilegeObjectDesc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67218/ --- (Updated June 26, 2018, 12:18 a.m.) Review request for sentry, kalyan kumar kal

Re: Review Request 67218: SENTRY-2238: Add support for DATABASE in show grant on command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67218/ --- (Updated June 26, 2018, 12:18 a.m.) Review request for sentry, kalyan kumar kal

Re: Review Request 67539: SENTRY-2264: It is possible to elevate privileges from DROP using alter table rename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67539/#review205315 --- Sentry should be able to differenciate if the just table rename or

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 25, 2018, 4:23 p.m., Fahd Siddiqui wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > > Line 52 (original), 52 (patched) > > > > > > It did cause com

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205297 --- Ship it! Ship It! - kalyan kumar kalvagadda On June 22, 2018

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 25, 2018, 4:23 p.m., Fahd Siddiqui wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > > Line 52 (original), 52 (patched) > > > > > > It did cause com

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

> On June 25, 2018, 3:28 p.m., kalyan kumar kalvagadda wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > > Line 52 (original), 52 (patched) > > > > > > How co

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205294 --- sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/h

Re: Review Request 67658: SENTRY-2269: Make SentryStore pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67658/#review205290 --- sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/h

[DISCUSS] Abstract JDO, DB transactions and retries into a separate SentryDataStore interface

Hey All, I'd like to discuss a design improvement of the SentryStore implementation. This class is currently used to deal with data stored in the Sentry database. I noticed that this class is always changing and new public methods are added to deal with data in several ways. For instance, we hav

Re: Review Request 67180: SENTRY-2235: Add hive tests to verify column privileges for views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67180/#review205287 --- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/te