Re: Review Request 68831: SENTRY-2417: fix LocalGroupMappingService INI format class docs

2018-09-24 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68831/#review208979 --- Ship it! Ship It! - Alexander Kolbasov On Sept. 24, 2018, 11

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208972 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
> On Sept. 24, 2018, 11:23 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 915 (patched) > > > > > > you have g

Re: Review Request 68831: SENTRY-2417: fix LocalGroupMappingService INI format class docs

2018-09-24 Thread Dan Burkert
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68831/ --- (Updated Sept. 24, 2018, 11:45 p.m.) Review request for sentry, Alexander Kolba

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208969 --- sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org

Re: Review Request 68727: SENTRY-2306: Reduce the HMS snapshot size by ignoring partitions at default locations

2018-09-24 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68727/ --- (Updated Sept. 24, 2018, 10:28 p.m.) Review request for sentry, Alexander Kolba

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
> On Sept. 24, 2018, 3:35 p.m., Sergio Pena wrote: > > Btw, are you going to have another JIRA for the client to call this new API? > > Hao Hao wrote: > Sure, I can create a jira for adding the client side logical. SENTRY-2418 is filed. - Hao

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/ --- (Updated Sept. 24, 2018, 9:31 p.m.) Review request for sentry, Na Li and Sergio

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Hao Hao via Review Board
> On Sept. 24, 2018, 3:35 p.m., Sergio Pena wrote: > > Btw, are you going to have another JIRA for the client to call this new API? Sure, I can create a jira for adding the client side logical. - Hao --- This is an automatically generat

Re: Review Request 68788: SENTRY-2413: Provide a configuration option to permit specific DB privileges to be granted explicitly

2018-09-24 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68788/#review208957 --- Ship it! Ship It! - Na Li On Sept. 21, 2018, 2:24 p.m., Serg

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208950 --- Btw, are you going to have another JIRA for the client to call thi

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

2018-09-24 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review208947 --- Fix it, then Ship it! It looks good. Just change the entityNam

Re: Review Request 68788: SENTRY-2413: Provide a configuration option to permit specific DB privileges to be granted explicitly

2018-09-24 Thread Sergio Pena via Review Board
> On Sept. 21, 2018, 5:18 p.m., kalyan kumar kalvagadda wrote: > > Sergio, > > > > Sentry server is policy store and does not need to understand the > > action.Let's keep it that way. Logic of validiting the actions is present > > in the sentry bindings. I think this logic should go there inst