Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

2018-10-16 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/ --- (Updated Oct. 16, 2018, 9:55 p.m.) Review request for sentry, kalyan kumar kalv

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

2018-10-16 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/ --- (Updated Oct. 16, 2018, 9:54 p.m.) Review request for sentry, kalyan kumar kalv

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

2018-10-16 Thread Arjun Mishra via Review Board
> On Oct. 16, 2018, 3:25 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3460-3462 (patched) > > > > > > Co

Re: Review Request 69030: SENTRY-2427: Use Hadoop KerberosName class to derive shortName

2018-10-16 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69030/#review209658 --- Ship it! Ship It! - Na Li On Oct. 16, 2018, 4:17 p.m., Arjun

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

2018-10-16 Thread Arjun Mishra via Review Board
> On Oct. 16, 2018, 3:25 p.m., Sergio Pena wrote: > > Could you test this log message and paste the real messages here? Sergio, this is how the real message will look like: 2018-10-16 12:43:00,322 INFO org.apache.sentry.service.thrift.HMSFollower: Persisting full snapshot for notification Id =

Re: Review Request 69030: SENTRY-2427: Use Hadoop KerberosName class to derive shortName

2018-10-16 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69030/ --- (Updated Oct. 16, 2018, 4:17 p.m.) Review request for sentry, kalyan kumar kalv

Re: Review Request 68958: SENTRY-2419: Log where sentry stands in the process of persisting the snpashot

2018-10-16 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/#review209627 --- Could you test this log message and paste the real messages here?

Re: Review Request 69030: SENTRY-2427: Use Hadoop KerberosName class to derive shortName

2018-10-16 Thread Arjun Mishra via Review Board
> On Oct. 15, 2018, 10:38 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestGSSCallback.java > > Lines 52 (patched) > > > > > > You never set HADOOP_SECURIT