Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-20 Thread Steve Moist via Review Board
> On Nov. 20, 2018, 6:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js > > Lines 32 (patched) > > > > > > Why do we have 2 different copyrights? Is th

Review Request 69415: SENTRY-2463: Revoking ALL or * should revoke any other privilege on the entity

2018-11-20 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69415/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. Bug

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-20 Thread Brian Towles via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/ --- (Updated Nov. 20, 2018, 1:30 p.m.) Review request for sentry, Anthony Young-Gar

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-20 Thread Brian Towles via Review Board
> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-dist/pom.xml > > Lines 66 (patched) > > > > > > You did an exclusion of * above, why not do it again here? It didnt work. I ended up for some reason need

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

2018-11-20 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210669 --- sentry-dist/pom.xml Lines 66 (patched)

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210731 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210730 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210728 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
> On Nov. 20, 2018, 5:08 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > > Lines 179 (patched) > > > > > > can you set t

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210726 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen

Re: Review Request 69087: SENTRY-2249: Enable batch insert of HMS paths in Full Snapshot.

2018-11-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210722 --- sentry-service/sentry-service-server/src/main/java/org/apache/sen