Re: Review Request 70004: SENTRY-2496 Support multi-field attribute based document level controls for Solr

2019-02-20 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70004/#review212966 --- Ship it! Ship It! - Hrishikesh Gadre On Feb. 18, 2019, 2:36

Re: Review Request 69619: SENTRY-2482: Sentry Solr to support multi-attribute document level security

2019-01-18 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69619/#review212158 --- Ship it! Ship It! - Hrishikesh Gadre On Jan. 15, 2019, 9:49

Re: Review Request 69619: SENTRY-2482: Sentry Solr to support multi-attribute document level security

2019-01-11 Thread Hrishikesh Gadre via Review Board
> On Jan. 7, 2019, 9:37 p.m., Hrishikesh Gadre wrote: > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/CachingUserAttributeSource.java > > Lines 34 (patched) > > > > > > Can we use

Re: Review Request 69619: SENTRY-2482: Sentry Solr to support multi-attribute document level security

2019-01-07 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69619/#review211740 ---

Review Request 66019: SENTRY-2178 Perform case insensitive comparison of permissions in the migration tool

2018-03-09 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66019/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Bugs:

Re: Review Request 64040: SENTRY-2070: TestSentryShellSolr tests are case sensitive to privileges

2017-11-22 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64040/#review191761 --- Although this change looks harmless, I am trying to understand

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

2017-11-21 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63878/ --- (Updated Nov. 21, 2017, 7:08 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

2017-11-21 Thread Hrishikesh Gadre via Review Board
> On Nov. 16, 2017, 10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolCommon.java > > Lines 236 (patched) > >

Re: Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

2017-11-21 Thread Hrishikesh Gadre via Review Board
> On Nov. 16, 2017, 10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/PermissionsMigrationToolCommon.java > > Lines 218 (patched) > >

Review Request 63878: [SENTRY-1480] Solr/Sentry permissions migration tool

2017-11-16 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63878/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Bugs:

Review Request 63762: [solr] SENTRY-2042 Support file based Sentry provider for Solr plugin

2017-11-13 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63762/ --- Review request for sentry, kalyan kumar kalvagadda and Sergio Pena. Bugs:

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-08 Thread Hrishikesh Gadre via Review Board
> On Nov. 8, 2017, 6:55 p.m., Sergio Pena wrote: > > pom.xml > > Line 94 (original), 94 (patched) > > > > > > This version is already set on SENTRY-1997. Could you rebase your patch? I have already rebased my

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-08 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/ --- (Updated Nov. 8, 2017, 6:15 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-06 Thread Hrishikesh Gadre via Review Board
> On Nov. 3, 2017, 10:33 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/SolrModelAuthorizable.java > > Lines 21 (patched) > > > > > > why

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-03 Thread Hrishikesh Gadre via Review Board
> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SentrySolrPluginImpl.java > > Lines 232 (patched) > > > > > >

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-11-03 Thread Hrishikesh Gadre via Review Board
> On Nov. 1, 2017, 8:42 p.m., kalyan kumar kalvagadda wrote: > > sentry-core/sentry-core-model-solr/src/main/java/org/apache/sentry/core/model/solr/Admin.java > > Lines 26 (patched) > > > > > > Here name Admin

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-10-29 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/ --- (Updated Oct. 29, 2017, 10:19 p.m.) Review request for sentry and Sergio Pena.

Re: Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-10-24 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/ --- (Updated Oct. 24, 2017, 7:42 p.m.) Review request for sentry and Sergio Pena.

Review Request 63250: [SENTRY-1475] SOLR/Sentry authorization plugin (with solr 7)

2017-10-24 Thread Hrishikesh Gadre via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63250/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-1475